[PATCH net-next] etherdevice: introduce help function eth_zero_addr()

[PATCH net-next] etherdevice: introduce help function eth_zero_addr()

[Duan Jiong]

a lot of code has either the memset or an inefficient copy
from a static array that contains the all-zeros Ethernet address.
Introduce help function eth_zero_addr() to fill an address with
all zeros, making the code clearer and allowing us to get rid of
some constant arrays.

Signed-off-by: Duan Jiong <djduanjiong@gmail.com>
---
 include/linux/etherdevice.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index d426336..b006ba0 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -151,6 +151,17 @@ static inline void eth_broadcast_addr(u8 *addr)
 }
 
 /**
+ * eth_zero_addr - Assign zero address
+ * @addr: Pointer to a six-byte array containing the Ethernet address
+ *
+ * Assign the zero address to the given address array.
+ */
+static inline void eth_zero_addr(u8 *addr)
+{
+	memset(addr, 0x00, ETH_ALEN);
+}
+
+/**
  * eth_hw_addr_random - Generate software assigned random Ethernet and
  * set device flag
  * @dev: pointer to net_device structure
-- 
1.7.11.4

Re: [PATCH net-next] etherdevice: introduce help function eth_zero_addr()

[David Miller]

From: Duan Jiong <djduanjiong@gmail.com>
Date: Sun, 09 Sep 2012 10:32:28 +0800

> a lot of code has either the memset or an inefficient copy
> from a static array that contains the all-zeros Ethernet address.
> Introduce help function eth_zero_addr() to fill an address with
> all zeros, making the code clearer and allowing us to get rid of
> some constant arrays.
> 
> Signed-off-by: Duan Jiong <djduanjiong@gmail.com>

Applied, thanks.