From: Cong Wang <xiyou.wangcong@gmail.com>
To: Sylvain Munaut <s.munaut@whatever-company.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Subject: Re: NULL deref in bnx2 / crashes ? ( was: netconsole leads to stalled CPU task )
Date: Mon, 17 Sep 2012 23:17:26 +0800 [thread overview]
Message-ID: <50573F06.90609@gmail.com> (raw)
In-Reply-To: <CAF6-1L4VaG4JAK0kYYizMvhBcaUM5x3uatA7JpzZqzcJ+fmGww@mail.gmail.com>
On 09/17/2012 06:57 PM, Sylvain Munaut wrote:
> Hi,
>
>>> Anyway, I think Eric is right, the bug may be in other place. I am wondering
>>> if the attached patch could help? It seems in netpoll tx path, we miss the
>>> chance of calling ->ndo_select_queue().
>>>
>>> Please give it a try.
>>
>> This fixes the NULL deref as well. I applied your patch over vanilla
>> 3.6-rc5 (so without eric's patch) and I can load netconsole without it
>> crashing directly.
>>
>> I will try to put a bit of load on the machine and see how it behaves,
>> if it solves the hung cpu tasks as well.
>
> So far so good, the machine is still alive and well after 3 days with
> netconsole enabled.
>
Great!
Thanks a lot for testing, Sylvain! I will post the patch tomorrow, as I
need some sleep now. :)
prev parent reply other threads:[~2012-09-17 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 10:53 NULL deref in bnx2 / crashes ? ( was: netconsole leads to stalled CPU task ) Sylvain Munaut
2012-08-22 11:13 ` Eric Dumazet
2012-08-22 12:17 ` Sylvain Munaut
2012-08-22 13:05 ` Eric Dumazet
2012-08-22 14:29 ` Sylvain Munaut
2012-08-22 15:40 ` Cong Wang
2012-08-23 7:57 ` Cong Wang
2012-08-23 8:31 ` Cong Wang
2012-08-23 9:12 ` Cong Wang
2012-08-24 9:50 ` Sylvain Munaut
2012-08-25 8:01 ` Cong Wang
2012-08-25 2:20 ` Lin Ming
2012-09-12 11:53 ` Sylvain Munaut
2012-09-12 12:49 ` Cong Wang
2012-09-12 13:05 ` Eric Dumazet
2012-09-13 17:35 ` Sylvain Munaut
2012-09-14 13:22 ` Cong Wang
2012-09-14 15:36 ` Sylvain Munaut
2012-09-17 10:57 ` Sylvain Munaut
2012-09-17 15:17 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50573F06.90609@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=s.munaut@whatever-company.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).