From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next] tcp: remove SG-related comment in tcp_sendmsg()
Date: Fri, 6 Jul 2018 03:08:07 -0700
Message-ID: <5057f0d2-1d48-1665-8f9b-6123f7d3302c@gmail.com>
References: <20180706071910.65958-1-jwi@linux.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Julian Wiedmann <jwi@linux.ibm.com>,
        David Miller <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f194.google.com ([209.85.192.194]:35201 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753519AbeGFKIK (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 6 Jul 2018 06:08:10 -0400
Received: by mail-pf0-f194.google.com with SMTP id q7-v6so6944890pff.2
        for <netdev@vger.kernel.org>; Fri, 06 Jul 2018 03:08:10 -0700 (PDT)
In-Reply-To: <20180706071910.65958-1-jwi@linux.ibm.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 07/06/2018 12:19 AM, Julian Wiedmann wrote:
> Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code
> doesn't care whether the interface supports SG.
> 
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
> ---
>  net/ipv4/tcp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index bf461fa77ed6..516e89b57603 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1275,9 +1275,7 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
>  			int linear;
>  
>  new_segment:
> -			/* Allocate new segment. If the interface is SG,
> -			 * allocate skb fitting to single page.
> -			 */
> +			/* Allocate new segment. */

Hi Julian

Please remove the comment completely then, it is really just redundant after this label.

Thanks.