From: Alexander Duyck <alexander.duyck@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
alexander.h.duyck@intel.com, tushar.n.dave@intel.com,
john.r.fastabend@intel.com, mirqus@gmail.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net] e1000: Small packets may get corrupted during padding by HW
Date: Mon, 17 Sep 2012 22:55:43 -0700 [thread overview]
Message-ID: <50580CDF.5050108@gmail.com> (raw)
In-Reply-To: <1347947120.26523.207.camel@edumazet-glaptop>
On 9/17/2012 10:45 PM, Eric Dumazet wrote:
> On Mon, 2012-09-17 at 20:27 -0700, Alexander Duyck wrote:
>
>> It also just occurred to me that there might be some benefit in cache
>> aligning the max header size. It seems like doing something like that
>> should reduce the overall memory footprint and would probably improve
>> performance.
> Given that most ACK packets are 66 bytes (14 ethernet + 20 IP + 32 TCP),
> I am not sure we need to make any tweak on alignment ?
I'm honestly not sure myself. I will probably spend a few hours
tomorrow tweaking a few things to test and see if there is any gain to
be had there. The only reason why it occurred to me is that it really
isn't too far off from what we did back on the Rx side, except for there
we were aligning at the start of the buffer and working our way up.
Thanks,
Alex
next prev parent reply other threads:[~2012-09-18 5:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 20:16 [net] e1000: Small packets may get corrupted during padding by HW Jeff Kirsher
2012-09-15 20:44 ` Michał Mirosław
2012-09-16 1:25 ` Dave, Tushar N
2012-09-16 1:48 ` John Fastabend
2012-09-16 2:30 ` John Fastabend
2012-09-17 7:33 ` Dave, Tushar N
2012-09-17 7:58 ` Eric Dumazet
2012-09-17 20:53 ` Alexander Duyck
2012-09-17 21:02 ` Eric Dumazet
2012-09-18 3:01 ` Alexander Duyck
2012-09-18 3:03 ` David Miller
2012-09-18 3:27 ` Alexander Duyck
2012-09-18 5:45 ` Eric Dumazet
2012-09-18 5:55 ` Alexander Duyck [this message]
2012-09-17 16:31 ` David Miller
2012-09-17 16:39 ` Dave, Tushar N
2012-09-17 19:40 ` Alexander Duyck
2012-09-18 20:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50580CDF.5050108@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.r.fastabend@intel.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=tushar.n.dave@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).