From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <havard@skinnemoen.net>,
<bhutchings@solarflare.com>,
<linux-arm-kernel@lists.infradead.org>, <plagnioj@jcrosoft.com>,
<patrice.vilchez@atmel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/9] net/macb: driver enhancement concerning GEM support, ring logic and cleanup
Date: Thu, 20 Sep 2012 15:03:21 +0200 [thread overview]
Message-ID: <505B1419.2070706@atmel.com> (raw)
In-Reply-To: <20120919.135006.394934820049386022.davem@davemloft.net>
On 09/19/2012 07:50 PM, David Miller :
> From: Nicolas Ferre <nicolas.ferre@atmel.com>
> Date: Wed, 19 Sep 2012 13:55:13 +0200
>
>> This is an enhancement work that began several years ago. I try to catchup with
>> some performance improvement that has been implemented then by Havard.
>> The ring index logic and the TX error path modification are the biggest changes
>> but some cleanup/debugging have been added along the way.
>> The GEM revision will benefit from the Gigabit support.
>>
>> The series has been tested on several Atmel AT91 SoC with the two MACB/GEM
>> flavors.
>>
>> v2: - modify the tx error handling: now uses a workqueue
>> - information provided by ethtool -i were not accurate: removed
>
> Don't submit patches like this.
>
> When you put an RFC right in the middle of the series, it screws everything
> up.
>
> It means that I can't only apply the parts that are not RFC.
I will submit a v3 patch series when I am more confident about the patch
that I have tagged as RFC...
And as you noted last time that I have included a modified patch in a
series:
"Please, when you receive feedback on your patches, you need to
resubmit the whole patch series for review not just the patches where
changes were asked for."
==> I thought that it was a better idea to post the whole patch series
so that people could figure out the context. As the TX error path is
greatly modified, it could make senses.
Now, is it possible to review this series as it is or should I repost
patches? attached to the previous thread? RFC patch alone?
puzzled,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-09-20 13:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:55 [PATCH v2 0/9] net/macb: driver enhancement concerning GEM support, ring logic and cleanup Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 1/9] net/macb: Add support for Gigabit Ethernet mode Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 2/9] net/macb: memory barriers cleanup Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 3/9] net/macb: change debugging messages Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 4/9] net/macb: remove macb_get_drvinfo() Nicolas Ferre
2012-09-19 15:10 ` Ben Hutchings
2012-09-19 11:55 ` [PATCH v2 5/9] net/macb: tx status is more than 8 bits now Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 6/9] net/macb: clean up ring buffer logic Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 7/9] net/macb: ethtool interface: add register dump feature Nicolas Ferre
2012-09-19 15:14 ` Ben Hutchings
2012-09-19 11:55 ` [RFC PATCH v2 8/9] net/macb: better manage tx errors Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 9/9] net/macb: Offset first RX buffer by two bytes Nicolas Ferre
2012-09-19 17:50 ` [PATCH v2 0/9] net/macb: driver enhancement concerning GEM support, ring logic and cleanup David Miller
2012-09-20 13:03 ` Nicolas Ferre [this message]
2012-10-26 15:25 ` Nicolas Ferre
2012-10-26 18:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B1419.2070706@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=havard@skinnemoen.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=patrice.vilchez@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).