From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [RFC PATCHv2 bridge 7/7] bridge: Add the ability to show dump the vlan map from a bridge port Date: Mon, 24 Sep 2012 16:29:28 -0400 Message-ID: <5060C2A8.3040908@redhat.com> References: <1348058536-22607-1-git-send-email-vyasevic@redhat.com> <1348058536-22607-8-git-send-email-vyasevic@redhat.com> <1348334132.2521.100.camel@bwh-desktop.uk.solarflarecom.com> <20120922.132747.1937291269030903700.davem@davemloft.net> <20120922130553.3d7e0299@nehalam.linuxnetplumber.net> <50606500.1040102@redhat.com> <1348511955.10741.4.camel@deadeye.wl.decadent.org.uk> Reply-To: vyasevic@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , David Miller , netdev@vger.kernel.org To: Ben Hutchings Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372Ab2IXU3c (ORCPT ); Mon, 24 Sep 2012 16:29:32 -0400 In-Reply-To: <1348511955.10741.4.camel@deadeye.wl.decadent.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: On 09/24/2012 02:39 PM, Ben Hutchings wrote: > On Mon, 2012-09-24 at 09:49 -0400, Vlad Yasevich wrote: >> On 09/22/2012 04:05 PM, Stephen Hemminger wrote: >>> On Sat, 22 Sep 2012 13:27:47 -0400 (EDT) >>> David Miller wrote: >>> >>>> From: Ben Hutchings >>>> Date: Sat, 22 Sep 2012 18:15:32 +0100 >>>> >>>>> On Wed, 2012-09-19 at 08:42 -0400, Vlad Yasevich wrote: >>>>>> Using the RTM_GETLINK dump the vlan map of a given bridge port. >>>>> [...] >>>>> >>>>> This enlarges the RTM_GETLINK response quite a bit. I think perhaps >>>>> this should be optional, like IFLA_VFINFO_LIST is now. >>>> >>>> Completely agreed. >>> >>> Since most users won't use it, it should be not necessary to include >>> it if the map is blank. >>> >> >> Response is included only for AF_BRIDGE calls (proably used by STP >> implementation) and only when vlan filtering is configured. >> >> I do see the point though and can add a filter for this. > > I thought the per-AF stuff was included by default (or at least what > most clients ask for). If not then this is probably fine. > IFLA_VFINFO_LIST was causing glibc's queries to fail and that must be > avoided. > > Ben. > Not just that. This is a PF_BRIDGE family request. Note the err = __rtnl_register(PF_BRIDGE, RTM_GETLINK, NULL, br_dump_ifinfo, NULL); in br_netlink_init. -vlad