From: Haicheng Li <haicheng.li@linux.intel.com>
To: Haicheng Li <haicheng.li@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Takahiroi Shimizu <tshimizu818@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
haicheng.lee@gmail.com
Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.
Date: Tue, 25 Sep 2012 08:23:27 +0800 [thread overview]
Message-ID: <5060F97F.3040809@linux.intel.com> (raw)
In-Reply-To: <506009A4.8000202@linux.intel.com>
From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001
From: Haicheng Li <haicheng.li@linux.intel.com>
Date: Mon, 24 Sep 2012 15:52:30 +0800
Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.
The .config is:
CONFIG_PCH_GBE=y
CONFIG_PCH_PTP=y
CONFIG_PTP_1588_CLOCK=m
The build error:
drivers/built-in.o: In function `pch_tx_timestamp':
.../pch_gbe_main.c:215: undefined reference to `pch_ch_event_read'
.../pch_gbe_main.c:225: undefined reference to `pch_tx_snap_read'
.../pch_gbe_main.c:231: undefined reference to `pch_ch_event_write'
.../pch_gbe_main.c:170: undefined reference to `pch_ch_event_read'
.../pch_gbe_main.c:175: undefined reference to `pch_src_uuid_lo_read'
.../pch_gbe_main.c:176: undefined reference to `pch_src_uuid_hi_read'
.../pch_gbe_main.c:190: undefined reference to `pch_ch_event_write'
.../pch_gbe_main.c:184: undefined reference to `pch_rx_snap_read'
.../pch_gbe_main.c:267: undefined reference to `pch_ch_control_write'
.../pch_gbe_main.c:271: undefined reference to `pch_ch_control_write'
.../pch_gbe_main.c:275: undefined reference to `pch_ch_control_write'
.../pch_gbe_main.c:281: undefined reference to `pch_ch_control_write'
.../pch_gbe_main.c:283: undefined reference to `pch_set_station_address'
.../pch_gbe_main.c:290: undefined reference to `pch_ch_event_write'
Signed-off-by: Haicheng Li <haicheng.lee@gmail.com>
---
drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
index bce0164..6c8aed4 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
@@ -26,7 +26,7 @@ if PCH_GBE
config PCH_PTP
bool "PCH PTP clock support"
default n
- depends on PTP_1588_CLOCK_PCH
+ depends on PTP_1588_CLOCK_PCH = PCH_GBE
---help---
Say Y here if you want to use Precision Time Protocol (PTP) in the
driver. PTP is a method to precisely synchronize distributed clocks
--
1.7.1
next parent reply other threads:[~2012-09-25 0:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <506009A4.8000202@linux.intel.com>
2012-09-25 0:23 ` Haicheng Li [this message]
2012-09-27 22:09 ` [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency David Miller
2012-09-28 6:41 ` Haicheng Li
2012-09-28 6:46 ` David Miller
2012-09-28 6:57 ` Haicheng Li
2012-10-03 2:22 ` David Miller
2012-10-03 21:45 ` Ben Hutchings
2012-10-04 0:43 ` David Miller
2012-10-16 20:09 ` Ben Hutchings
2012-10-16 20:17 ` David Miller
2012-10-16 21:08 ` Keller, Jacob E
[not found] ` <50600A49.7040902@linux.intel.com>
2012-09-25 0:24 ` [PATCH 2/2] Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info Haicheng Li
2012-09-27 22:06 ` David Miller
2012-09-28 6:44 ` Haicheng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5060F97F.3040809@linux.intel.com \
--to=haicheng.li@linux.intel.com \
--cc=davem@davemloft.net \
--cc=haicheng.lee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tshimizu818@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).