From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haicheng Li Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. Date: Fri, 28 Sep 2012 14:41:43 +0800 Message-ID: <506546A7.7030500@linux.intel.com> References: <506009A4.8000202@linux.intel.com> <5060F97F.3040809@linux.intel.com> <20120927.180942.969924012897168294.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tshimizu818@gmail.com, linux-kernel@vger.kernel.org, haicheng.lee@gmail.com To: David Miller Return-path: In-Reply-To: <20120927.180942.969924012897168294.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/28/2012 06:09 AM, David Miller wrote: > Look at how other people submit patches, do any other patch submissions > look like your's having all of this metadata in the message body: I'm sorry for it. > As for this specific patch: > >> - depends on PTP_1588_CLOCK_PCH >> + depends on PTP_1588_CLOCK_PCH = PCH_GBE > > This is not the correct way to ensure that the module'ness of one > config option meets the module'ness requirements of another. > The correct way is to say something like "&& (PCH_GBE || PCH_GBE=n)" This case is a little bit tricky than usual, with PCH_PTP selected, the valid config would be either "PTP_1588_CLOCK_PCH=PCH_GBE=m" or "PTP_1588_CLOCK_PCH=PCH_GBE=y", and PTP_1588_CLOCK_PCH depends on PCH_GBE. So are you ok with this: + depends on PTP_1588_CLOCK_PCH && (PCH_GBE=m || PTP_1588_CLOCK_PCH=y) or simply like: --- From: Haicheng Li Fix build error caused by broken PCH_PTP module dependency. The .config is: CONFIG_PCH_GBE=y CONFIG_PCH_PTP=y CONFIG_PTP_1588_CLOCK=m The build error: drivers/built-in.o: In function `pch_tx_timestamp': .../pch_gbe_main.c:215: undefined reference to `pch_ch_event_read' .../pch_gbe_main.c:225: undefined reference to `pch_tx_snap_read' .../pch_gbe_main.c:231: undefined reference to `pch_ch_event_write' .../pch_gbe_main.c:170: undefined reference to `pch_ch_event_read' .../pch_gbe_main.c:175: undefined reference to `pch_src_uuid_lo_read' .../pch_gbe_main.c:176: undefined reference to `pch_src_uuid_hi_read' .../pch_gbe_main.c:190: undefined reference to `pch_ch_event_write' .../pch_gbe_main.c:184: undefined reference to `pch_rx_snap_read' .../pch_gbe_main.c:267: undefined reference to `pch_ch_control_write' .../pch_gbe_main.c:271: undefined reference to `pch_ch_control_write' .../pch_gbe_main.c:275: undefined reference to `pch_ch_control_write' .../pch_gbe_main.c:281: undefined reference to `pch_ch_control_write' .../pch_gbe_main.c:283: undefined reference to `pch_set_station_address' .../pch_gbe_main.c:290: undefined reference to `pch_ch_event_write' Signed-off-by: Haicheng Li --- drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig index bce0164..df1e649 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig @@ -21,12 +21,12 @@ config PCH_GBE ML7223/ML7831 is companion chip for Intel Atom E6xx series. ML7223/ML7831 is completely compatible for Intel EG20T PCH. -if PCH_GBE +if PTP_1588_CLOCK_PCH config PCH_PTP bool "PCH PTP clock support" default n - depends on PTP_1588_CLOCK_PCH + depends on PTP_1588_CLOCK_PCH=y || PCH_GBE=m ---help--- Say Y here if you want to use Precision Time Protocol (PTP) in the driver. PTP is a method to precisely synchronize distributed clocks -- 1.7.1 -haicheng