From: Haicheng Li <haicheng.li@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, tshimizu818@gmail.com,
linux-kernel@vger.kernel.org, haicheng.lee@gmail.com
Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.
Date: Fri, 28 Sep 2012 14:57:38 +0800 [thread overview]
Message-ID: <50654A62.5090003@linux.intel.com> (raw)
In-Reply-To: <20120928.024621.1635385815700269914.davem@davemloft.net>
On 09/28/2012 02:46 PM, David Miller wrote:
> From: Haicheng Li<haicheng.li@linux.intel.com>
> Date: Fri, 28 Sep 2012 14:41:43 +0800
>
>> On 09/28/2012 06:09 AM, David Miller wrote:
>>> Look at how other people submit patches, do any other patch
>>> submissions
>>> look like your's having all of this metadata in the message body:
>> I'm sorry for it.
>>
>>> As for this specific patch:
>>>
>>>> - depends on PTP_1588_CLOCK_PCH
>>>> + depends on PTP_1588_CLOCK_PCH = PCH_GBE
>>>
>>> This is not the correct way to ensure that the module'ness of one
>>> config option meets the module'ness requirements of another.
>>> The correct way is to say something like "&& (PCH_GBE || PCH_GBE=n)"
>>
>> This case is a little bit tricky than usual, with PCH_PTP selected,
>> the valid config would be either "PTP_1588_CLOCK_PCH=PCH_GBE=m" or
>> "PTP_1588_CLOCK_PCH=PCH_GBE=y", and PTP_1588_CLOCK_PCH depends on
>> PCH_GBE.
>
> And a simple "&& PCH_GBE" should accomplish this, no?
No sir. it's actually same with the original Kconfig (by a if PCH_GBE"), it
just failed with this config:
CONFIG_PCH_GBE=y
CONFIG_PCH_PTP=y
CONFIG_PTP_1588_CLOCK=m
-haicheng
next prev parent reply other threads:[~2012-09-28 6:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <506009A4.8000202@linux.intel.com>
2012-09-25 0:23 ` [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency Haicheng Li
2012-09-27 22:09 ` David Miller
2012-09-28 6:41 ` Haicheng Li
2012-09-28 6:46 ` David Miller
2012-09-28 6:57 ` Haicheng Li [this message]
2012-10-03 2:22 ` David Miller
2012-10-03 21:45 ` Ben Hutchings
2012-10-04 0:43 ` David Miller
2012-10-16 20:09 ` Ben Hutchings
2012-10-16 20:17 ` David Miller
2012-10-16 21:08 ` Keller, Jacob E
[not found] ` <50600A49.7040902@linux.intel.com>
2012-09-25 0:24 ` [PATCH 2/2] Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info Haicheng Li
2012-09-27 22:06 ` David Miller
2012-09-28 6:44 ` Haicheng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50654A62.5090003@linux.intel.com \
--to=haicheng.li@linux.intel.com \
--cc=davem@davemloft.net \
--cc=haicheng.lee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tshimizu818@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).