From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Jones Subject: Re: [PATCH] udp: increment UDP_MIB_NOPORTS in mcast receive Date: Wed, 03 Oct 2012 10:39:53 -0700 Message-ID: <506C7869.8030308@hp.com> References: <506955F3.8050304@googlemail.com> <1349082950.12401.669.camel@edumazet-glaptop> <20121001193434.GA14236@redhat.com> <20121001.160115.1816241312626722150.davem@davemloft.net> <1349121884.12401.721.camel@edumazet-glaptop> <1349192133.12401.768.camel@edumazet-glaptop> <1349192919.12401.778.camel@edumazet-glaptop> <1349249328.12401.1364.camel@edumazet-glaptop> <1349270151.12401.2372.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , chris2553@googlemail.com, Dave Jones , David Miller , gpiez@web.de, Julian Anastasov , netdev@vger.kernel.org, netdev-owner@vger.kernel.org To: David Stevens Return-path: Received: from g6t0184.atlanta.hp.com ([15.193.32.61]:37858 "EHLO g6t0184.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879Ab2JCRj5 (ORCPT ); Wed, 3 Oct 2012 13:39:57 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 10/03/2012 07:09 AM, David Stevens wrote: > Of course. I think our difference is on the definition of > "receives". I don't think a packet delivered locally due to > promiscuous mode, broadcast or an imperfect multicast address filter > match is a host UDP datagram receive. These packets really shouldn't > be delivered to UDP at all; they are not addressed to this host (at > least the non-broadcast, no-membership ones). A unicast UDP packet > that doesn't match a local IP address does not increment this > counter. A promiscuous mode multicast delivery is no different, > except that the destination alone doesn't tell us if it is for us. > > I think counting these will primarily lead to administrators seeing > non-zero drops and wasting their time trying to track them down. I would tend to agree with David on this one. Or they might cease trying to track them down because they've gotten so many "false positives." Isn't "meant for me" vs "not meant for me" at the heard of "drops" versus "discards?" Once the packet is in the host, is it tagged in some way with "this was received as promiscuous/whatnot?" rick