From: Graham Gower <graham.gower@gmail.com>
To: Jan Ceuleers <jan.ceuleers@computer.org>
Cc: netdev@vger.kernel.org, Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
Date: Mon, 08 Oct 2012 16:03:31 +1030 [thread overview]
Message-ID: <507265AB.5050107@gmail.com> (raw)
In-Reply-To: <50714C45.3080103@computer.org>
On 10/07/2012 08:02 PM, Jan Ceuleers wrote:
> On 10/07/2012 07:55 AM, Graham Gower wrote:
>> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>>
>> --- skge.c.bak 2012-10-07 13:00:56.000000000 +1030
>> +++ skge.c 2012-10-07 13:26:03.000000000 +1030
>> @@ -4143,6 +4143,13 @@
>
> Graham,
>
> Your patch should include the path to the file being patched relative to
> the base directory. So in this case something like
>
> --- a/drivers/net/ethernet/marvell/skge.c ...
> +++ b/drivers/net/ethernet/marvell/skge.c ...
>
> HTH, Jan
>
Thanks, I should know this stuff. Just an oversight because I was
too lazy to clone a repository and diffed against the single file.
-Graham
next prev parent reply other threads:[~2012-10-08 5:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 5:55 skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard Graham Gower
2012-10-07 9:32 ` Jan Ceuleers
2012-10-08 5:33 ` Graham Gower [this message]
2012-10-08 5:33 ` [PATCH v2] " Graham Gower
2012-10-08 5:36 ` David Miller
2012-10-08 5:54 ` [PATCH v3] " Graham Gower
2012-10-08 6:11 ` David Miller
2012-10-08 6:15 ` Graham Gower
2012-10-08 6:21 ` David Miller
2012-10-08 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507265AB.5050107@gmail.com \
--to=graham.gower@gmail.com \
--cc=jan.ceuleers@computer.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).