* skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
@ 2012-10-07 5:55 Graham Gower
2012-10-07 9:32 ` Jan Ceuleers
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Graham Gower @ 2012-10-07 5:55 UTC (permalink / raw)
To: netdev, Stephen Hemminger
Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
packets on a system with >4gb ram unless a 32bit DMA mask is used.
This issue has been around for years and a fix was sent 3.5 years ago, but
there was some debate as to whether it should instead be fixed as a PCI quirk.
http://www.spinics.net/lists/netdev/msg88670.html
However, 18 months later a similar workaround was introduced for another
chipset exhibiting the same problem.
http://www.spinics.net/lists/netdev/msg142287.html
Signed-off-by: Graham Gower <graham.gower@gmail.com>
--- skge.c.bak 2012-10-07 13:00:56.000000000 +1030
+++ skge.c 2012-10-07 13:26:03.000000000 +1030
@@ -4143,6 +4143,13 @@
DMI_MATCH(DMI_BOARD_NAME, "nForce"),
},
},
+ {
+ .ident = "ASUS P5NSLI",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
+ DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
+ },
+ },
{}
};
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-07 5:55 skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard Graham Gower
@ 2012-10-07 9:32 ` Jan Ceuleers
2012-10-08 5:33 ` Graham Gower
2012-10-08 5:33 ` [PATCH v2] " Graham Gower
2012-10-08 16:16 ` Stephen Hemminger
2 siblings, 1 reply; 10+ messages in thread
From: Jan Ceuleers @ 2012-10-07 9:32 UTC (permalink / raw)
To: Graham Gower; +Cc: netdev, Stephen Hemminger
On 10/07/2012 07:55 AM, Graham Gower wrote:
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>
> --- skge.c.bak 2012-10-07 13:00:56.000000000 +1030
> +++ skge.c 2012-10-07 13:26:03.000000000 +1030
> @@ -4143,6 +4143,13 @@
Graham,
Your patch should include the path to the file being patched relative to
the base directory. So in this case something like
--- a/drivers/net/ethernet/marvell/skge.c ...
+++ b/drivers/net/ethernet/marvell/skge.c ...
HTH, Jan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-07 9:32 ` Jan Ceuleers
@ 2012-10-08 5:33 ` Graham Gower
0 siblings, 0 replies; 10+ messages in thread
From: Graham Gower @ 2012-10-08 5:33 UTC (permalink / raw)
To: Jan Ceuleers; +Cc: netdev, Stephen Hemminger
On 10/07/2012 08:02 PM, Jan Ceuleers wrote:
> On 10/07/2012 07:55 AM, Graham Gower wrote:
>> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>>
>> --- skge.c.bak 2012-10-07 13:00:56.000000000 +1030
>> +++ skge.c 2012-10-07 13:26:03.000000000 +1030
>> @@ -4143,6 +4143,13 @@
>
> Graham,
>
> Your patch should include the path to the file being patched relative to
> the base directory. So in this case something like
>
> --- a/drivers/net/ethernet/marvell/skge.c ...
> +++ b/drivers/net/ethernet/marvell/skge.c ...
>
> HTH, Jan
>
Thanks, I should know this stuff. Just an oversight because I was
too lazy to clone a repository and diffed against the single file.
-Graham
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-07 5:55 skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard Graham Gower
2012-10-07 9:32 ` Jan Ceuleers
@ 2012-10-08 5:33 ` Graham Gower
2012-10-08 5:36 ` David Miller
2012-10-08 16:16 ` Stephen Hemminger
2 siblings, 1 reply; 10+ messages in thread
From: Graham Gower @ 2012-10-08 5:33 UTC (permalink / raw)
To: netdev, Stephen Hemminger
Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
packets on a system with >4gb ram unless a 32bit DMA mask is used.
This issue has been around for years and a fix was sent 3.5 years ago, but
there was some debate as to whether it should instead be fixed as a PCI quirk.
http://www.spinics.net/lists/netdev/msg88670.html
However, 18 months later a similar workaround was introduced for another
chipset exhibiting the same problem.
http://www.spinics.net/lists/netdev/msg142287.html
Signed-off-by: Graham Gower <graham.gower@gmail.com>
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -4143,6 +4143,13 @@
DMI_MATCH(DMI_BOARD_NAME, "nForce"),
},
},
+ {
+ .ident = "ASUS P5NSLI",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
+ DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
+ },
+ },
{}
};
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-08 5:33 ` [PATCH v2] " Graham Gower
@ 2012-10-08 5:36 ` David Miller
2012-10-08 5:54 ` [PATCH v3] " Graham Gower
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2012-10-08 5:36 UTC (permalink / raw)
To: graham.gower; +Cc: netdev, shemminger
From: Graham Gower <graham.gower@gmail.com>
Date: Mon, 08 Oct 2012 16:03:44 +1030
> + .ident = "ASUS P5NSLI",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> + DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
This is poorly formatted, and your commit message has newlines
in very abrupt places as if you formatted it in your email client
GUI rather than in a text editor.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-08 5:36 ` David Miller
@ 2012-10-08 5:54 ` Graham Gower
2012-10-08 6:11 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Graham Gower @ 2012-10-08 5:54 UTC (permalink / raw)
To: David Miller; +Cc: netdev, shemminger
Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
packets on a system with >4gb ram unless a 32bit DMA mask is used.
This issue has been around for years and a fix was sent 3.5 years ago, but
there was some debate as to whether it should instead be fixed as a PCI quirk.
http://www.spinics.net/lists/netdev/msg88670.html
However, 18 months later a similar workaround was introduced for another
chipset exhibiting the same problem.
http://www.spinics.net/lists/netdev/msg142287.html
Signed-off-by: Graham Gower <graham.gower@gmail.com>
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -4143,6 +4143,13 @@
DMI_MATCH(DMI_BOARD_NAME, "nForce"),
},
},
+ {
+ .ident = "ASUS P5NSLI",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
+ DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
+ },
+ },
{}
};
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-08 5:54 ` [PATCH v3] " Graham Gower
@ 2012-10-08 6:11 ` David Miller
2012-10-08 6:15 ` Graham Gower
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2012-10-08 6:11 UTC (permalink / raw)
To: graham.gower; +Cc: netdev, shemminger
From: Graham Gower <graham.gower@gmail.com>
Date: Mon, 08 Oct 2012 16:24:44 +1030
> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to
> send/receive
> packets on a system with >4gb ram unless a 32bit DMA mask is used.
This is still oddly formatted.
> + {
> + .ident = "ASUS P5NSLI",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
And this is even worse than before.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-08 6:11 ` David Miller
@ 2012-10-08 6:15 ` Graham Gower
2012-10-08 6:21 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Graham Gower @ 2012-10-08 6:15 UTC (permalink / raw)
To: David Miller; +Cc: netdev, shemminger
Thunderbird must be screwing it. I hate mail clients. If I just pipe
the message to 'mail',
with a correct 'From:' line is that ok, or do I have to figure
something else out?
On 8 October 2012 16:41, David Miller <davem@davemloft.net> wrote:
> From: Graham Gower <graham.gower@gmail.com>
> Date: Mon, 08 Oct 2012 16:24:44 +1030
>
>> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to
>> send/receive
>> packets on a system with >4gb ram unless a 32bit DMA mask is used.
>
> This is still oddly formatted.
>
>> + {
>> + .ident = "ASUS P5NSLI",
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
>
> And this is even worse than before.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-08 6:15 ` Graham Gower
@ 2012-10-08 6:21 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2012-10-08 6:21 UTC (permalink / raw)
To: graham.gower; +Cc: netdev, shemminger
From: Graham Gower <graham.gower@gmail.com>
Date: Mon, 8 Oct 2012 16:45:33 +1030
> Thunderbird must be screwing it. I hate mail clients. If I just pipe
> the message to 'mail',
> with a correct 'From:' line is that ok, or do I have to figure
> something else out?
Documentation/email-clients.txt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
2012-10-07 5:55 skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard Graham Gower
2012-10-07 9:32 ` Jan Ceuleers
2012-10-08 5:33 ` [PATCH v2] " Graham Gower
@ 2012-10-08 16:16 ` Stephen Hemminger
2 siblings, 0 replies; 10+ messages in thread
From: Stephen Hemminger @ 2012-10-08 16:16 UTC (permalink / raw)
To: Graham Gower; +Cc: netdev
On Sun, 07 Oct 2012 16:25:45 +1030
Graham Gower <graham.gower@gmail.com> wrote:
> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
> packets on a system with >4gb ram unless a 32bit DMA mask is used.
>
> This issue has been around for years and a fix was sent 3.5 years ago, but
> there was some debate as to whether it should instead be fixed as a PCI quirk.
> http://www.spinics.net/lists/netdev/msg88670.html
>
> However, 18 months later a similar workaround was introduced for another
> chipset exhibiting the same problem.
> http://www.spinics.net/lists/netdev/msg142287.html
>
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>
> --- skge.c.bak 2012-10-07 13:00:56.000000000 +1030
> +++ skge.c 2012-10-07 13:26:03.000000000 +1030
> @@ -4143,6 +4143,13 @@
> DMI_MATCH(DMI_BOARD_NAME, "nForce"),
> },
> },
> + {
> + .ident = "ASUS P5NSLI",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> + DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
> + },
> + },
> {}
> };
>
This fix is fine, but like Jan said it needs to be based at the
right place in the filesystem tree for inclusion.
I wonder if it would be a good idea to add a way to automatically
check for this quirk using the debug registers on the chip which allow
peeking. Using the test registers B3_RAM_DATA_LO/B3_RAM_DATA_HI.
The problem is that might introduce worse problems if it causes
DMA access to non-existent memory and trying to recover from the fault.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-10-08 16:16 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-07 5:55 skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard Graham Gower
2012-10-07 9:32 ` Jan Ceuleers
2012-10-08 5:33 ` Graham Gower
2012-10-08 5:33 ` [PATCH v2] " Graham Gower
2012-10-08 5:36 ` David Miller
2012-10-08 5:54 ` [PATCH v3] " Graham Gower
2012-10-08 6:11 ` David Miller
2012-10-08 6:15 ` Graham Gower
2012-10-08 6:21 ` David Miller
2012-10-08 16:16 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).