From: Jeff Kirsher <tarbal@gmail.com>
To: adam.niescierowicz@justnet.pl
Cc: Andre Tomt <andre@tomt.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
Netdev <netdev@vger.kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: 3.4.1 and 3.5-rc1 Packet lost at 250Mb/s
Date: Tue, 09 Oct 2012 21:59:27 -0700 [thread overview]
Message-ID: <507500AF.4080209@gmail.com> (raw)
In-Reply-To: <d29932d70fa2025a8b87b053d9d99953@justnet.pl>
On 10/09/2012 12:56 PM, Nieścierowicz Adam wrote:
> W dniu 08.10.2012 14:59, Andre Tomt napisał(a):
>
>> On 08. okt. 2012 14:32, Andre Tomt wrote:
>>
>>> On 08. okt. 2012 14:13, Eric Dumazet wrote:
>>>
>>>> On Mon, 2012-10-08 at 14:00 +0200, Andre Tomt wrote:
>>>>
>>>>> On 08. okt. 2012 12:49, Nieścierowicz Adam wrote:
>>>>>
>>>>>> W dniu 08.10.2012 11:47, Eric Dumazet napisał(a):
>>>>>>
>>>>>>> Anyway you dont say where are drops, (ifconfig give us very few
>>>>>>> drops)
>>>>>> you can see no losses(drop), but a temporary decline in traffic
>>>>>> on the interface to 0kb/s
>>>>> This sounds very familiar, could it be something similar to:
>>>>> http://marc.info/?l=linux-netdev&m=134594936016796&w=3 [1] The chip
>>>>> seems to be of the same family (though not model)
>>>> Yes, but Adam says 3.4.1 already has a problem, while commit
>>>> 2cb7a9cc008c25dc03314de563c00c107b3e5432 is in 3.5 only. Since Adam
>>>> uses Intel e1000e, it could be the BQL related problem.
>>> The other chips have had DMA burst flag enabled for longer, so that he
>>> sees the same problem in 3.4 while I'm not makes sense. Hmm, as 3.4 is
>>> when BQL went in (IIRC) it seems very likely that this BQL issue is the
>>> problem for both of us.
>>
>> To clarify; I think the DMA burst flag in the driver triggers the BQL
>> related issue. Judging by the patchwork link for wthresh=1 this seems
>> very related indeed.
>>
>> Removing the FLAG2_DMA_BURST flag for 82574 in the driver works for me.
>> Adam, it might be worth testing out a build on your system too with the
>> flag removed. If you try the attached patch (for 3.6, probably OK for
>> 3.5) and the problem dissapears, we are probably at least talking about
>> the same bug.
>
> after applying the patch everything looks good, no visible loss
>
> Do you expect to correct the bug in mainline?
Jesse Brandenburg is working on a patch for upstream currently to fix
the issue.
next prev parent reply other threads:[~2012-10-10 4:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 19:18 3.4.1 and 3.5-rc1 Packet lost at 250Mb/s Nieścierowicz Adam
2012-10-08 6:22 ` Eric Dumazet
2012-10-08 9:29 ` Nieścierowicz Adam
2012-10-08 9:47 ` Eric Dumazet
2012-10-08 10:49 ` Nieścierowicz Adam
2012-10-08 12:00 ` Andre Tomt
2012-10-08 12:06 ` Nieścierowicz Adam
2012-10-08 12:13 ` Eric Dumazet
2012-10-08 12:32 ` Andre Tomt
2012-10-08 12:59 ` Andre Tomt
2012-10-09 19:56 ` Nieścierowicz Adam
2012-10-10 4:59 ` Jeff Kirsher [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-06 9:47 Nieścierowicz Adam
2012-07-06 10:13 ` Eric Dumazet
2012-06-08 9:31 Nieścierowicz Adam
2012-06-08 8:58 Nieścierowicz Adam
2012-06-08 9:41 ` Eric Dumazet
2012-06-08 9:43 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507500AF.4080209@gmail.com \
--to=tarbal@gmail.com \
--cc=adam.niescierowicz@justnet.pl \
--cc=andre@tomt.net \
--cc=eric.dumazet@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).