* [PATCH 3.6.0- 2/3] net/mdio-octeon: use module_platform_driver macro
@ 2012-10-10 18:29 Srinivas KANDAGATLA
2012-10-10 18:46 ` David Daney
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas KANDAGATLA @ 2012-10-10 18:29 UTC (permalink / raw)
To: davem; +Cc: srinivas.kandagatla, bordug, netdev, david.daney, linville, kaloz
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
This patch removes some code duplication by using
module_platform_driver.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
drivers/net/phy/mdio-octeon.c | 14 +-------------
1 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/drivers/net/phy/mdio-octeon.c b/drivers/net/phy/mdio-octeon.c
index d4015aa..84f7c47 100644
--- a/drivers/net/phy/mdio-octeon.c
+++ b/drivers/net/phy/mdio-octeon.c
@@ -196,19 +196,7 @@ void octeon_mdiobus_force_mod_depencency(void)
/* Let ethernet drivers force us to be loaded. */
}
EXPORT_SYMBOL(octeon_mdiobus_force_mod_depencency);
-
-static int __init octeon_mdiobus_mod_init(void)
-{
- return platform_driver_register(&octeon_mdiobus_driver);
-}
-
-static void __exit octeon_mdiobus_mod_exit(void)
-{
- platform_driver_unregister(&octeon_mdiobus_driver);
-}
-
-module_init(octeon_mdiobus_mod_init);
-module_exit(octeon_mdiobus_mod_exit);
+module_platform_driver(octeon_mdiobus_driver);
MODULE_DESCRIPTION(DRV_DESCRIPTION);
MODULE_VERSION(DRV_VERSION);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3.6.0- 2/3] net/mdio-octeon: use module_platform_driver macro
2012-10-10 18:29 [PATCH 3.6.0- 2/3] net/mdio-octeon: use module_platform_driver macro Srinivas KANDAGATLA
@ 2012-10-10 18:46 ` David Daney
0 siblings, 0 replies; 2+ messages in thread
From: David Daney @ 2012-10-10 18:46 UTC (permalink / raw)
To: Srinivas KANDAGATLA, davem; +Cc: bordug, netdev, david.daney, linville, kaloz
On 10/10/2012 11:29 AM, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch removes some code duplication by using
> module_platform_driver.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Acked-by: David Daney <david.daney@cavium.com>
I have the same thing locally, but you beat me to sending it in.
> ---
> drivers/net/phy/mdio-octeon.c | 14 +-------------
> 1 files changed, 1 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/phy/mdio-octeon.c b/drivers/net/phy/mdio-octeon.c
> index d4015aa..84f7c47 100644
> --- a/drivers/net/phy/mdio-octeon.c
> +++ b/drivers/net/phy/mdio-octeon.c
> @@ -196,19 +196,7 @@ void octeon_mdiobus_force_mod_depencency(void)
> /* Let ethernet drivers force us to be loaded. */
> }
> EXPORT_SYMBOL(octeon_mdiobus_force_mod_depencency);
> -
> -static int __init octeon_mdiobus_mod_init(void)
> -{
> - return platform_driver_register(&octeon_mdiobus_driver);
> -}
> -
> -static void __exit octeon_mdiobus_mod_exit(void)
> -{
> - platform_driver_unregister(&octeon_mdiobus_driver);
> -}
> -
> -module_init(octeon_mdiobus_mod_init);
> -module_exit(octeon_mdiobus_mod_exit);
> +module_platform_driver(octeon_mdiobus_driver);
>
> MODULE_DESCRIPTION(DRV_DESCRIPTION);
> MODULE_VERSION(DRV_VERSION);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-10 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 18:29 [PATCH 3.6.0- 2/3] net/mdio-octeon: use module_platform_driver macro Srinivas KANDAGATLA
2012-10-10 18:46 ` David Daney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).