netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dong Aisheng-B29396 <B29396@freescale.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Linux-CAN <linux-can@vger.kernel.org>,
	Hui Wang <jason77.wang@gmail.com>
Subject: Re: [PATCH] flexcan: disable bus error interrupts for the i.MX28
Date: Wed, 10 Oct 2012 22:04:42 +0200	[thread overview]
Message-ID: <5075D4DA.7010407@pengutronix.de> (raw)
In-Reply-To: <7FE21149F4667147B645348EC60578850B2A361F@039-SN2MPN1-011.039d.mgd.msft.net>

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

On 10/08/2012 09:59 AM, Dong Aisheng-B29396 wrote:
[...]

>>>> Concerning the bug, I know that the i.MX35 does have it. Maybe other
>>>> Flexcan cores than on the i.MX28 does *not* have it either. If you
>>>> have a chance, please check on the P1010, i.MX6Q, i.MX51, i.MX53,
>>>> etc.
>>>
>>> >From what I can tell, i.MX35, i.MX51 and i.MX53 use the same version,
>>> so they should all have the bug.  And for i.MX6Q, since it uses a
>>> newer version even than i.MX28, I would believe it's affected by the bug.
>>> But I'm copying Dong who should have better knowledge about this to
>>> confirm.
>>
>> Thank for clarification. I have a i.MX6Q board but without CAN adapter :(,
>> unfortunately. Otherwise I would try it out myself.
>>
> How did you verify this issue?
> I just checked our ic guy of flexcan, it seems he also had no sense of this issue.

Wolfgang added this table to the driver code, which is a very good idea.
I've some (nitpicky) questions :)

> Below is some version info what I got:
> Mx6s use FlexCAN3, with IP version 10.00.12.00
    ^^^
Is this core different from the mx6q? Has the flexcan on mx6 a glitch
filter?

> Mx53 use FlexCAN2 (with glitch filter), with IP version 03.00.00.00
> Mx28 use FlexCAN2 (with glitch filter), with IP version 03.00.04.00
> Mx35 use FlexCAN2 (without glitch filter) , with IP version 03.00.00.00
> Mx25 use FlexCAN2 (without glitch filter), with IP version 03.00.00.00

Do you have access to the powerpc designs which have a flexcan core,
too? I'm interested to complete the above table with powerpcs cores
(p1010 and similar).

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

  parent reply	other threads:[~2012-10-10 20:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28 13:17 [PATCH] flexcan: disable bus error interrupts for the i.MX28 Wolfgang Grandegger
2012-09-29  6:00 ` Hui Wang
2012-10-07  3:09 ` Shawn Guo
2012-10-07 14:48   ` Wolfgang Grandegger
2012-10-08  7:59     ` Dong Aisheng-B29396
2012-10-08  9:03       ` Wolfgang Grandegger
2012-10-08  9:13         ` Dong Aisheng-B29396
2012-10-08  9:31           ` Marc Kleine-Budde
2012-10-08  9:42             ` Dong Aisheng-B29396
2012-10-09 11:52             ` Dong Aisheng-B29396
2012-10-09 12:32               ` Wolfgang Grandegger
2012-10-10 20:04       ` Marc Kleine-Budde [this message]
2012-10-11  1:41         ` Dong Aisheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5075D4DA.7010407@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=B29396@freescale.com \
    --cc=jason77.wang@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).