From: Vlad Yasevich <vyasevich@gmail.com>
To: nicolas.dichtel@6wind.com
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
Zijie Pan <zijie.pan@6wind.com>
Subject: Re: [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter()
Date: Mon, 15 Oct 2012 11:40:38 -0400 [thread overview]
Message-ID: <507C2E76.3030801@gmail.com> (raw)
In-Reply-To: <1350309399-23422-1-git-send-email-nicolas.dichtel@6wind.com>
On 10/15/2012 09:56 AM, nicolas.dichtel@6wind.com wrote:
> From: Zijie Pan <zijie.pan@6wind.com>
>
> Bug introduced by commit edfee0339e681a784ebacec7e8c2dc97dc6d2839
> (sctp: check src addr when processing SACK to update transport state)
>
> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Shutdown case.. ACK.
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
> ---
> net/sctp/sm_sideeffect.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 57f7de8..6773d78 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -1642,8 +1642,9 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
> asoc->outqueue.outstanding_bytes;
> sackh.num_gap_ack_blocks = 0;
> sackh.num_dup_tsns = 0;
> + chunk->subh.sack_hdr = &sackh;
> sctp_add_cmd_sf(commands, SCTP_CMD_PROCESS_SACK,
> - SCTP_SACKH(&sackh));
> + SCTP_CHUNK(chunk));
> break;
>
> case SCTP_CMD_DISCARD_PACKET:
>
next prev parent reply other threads:[~2012-10-15 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 13:56 [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter() nicolas.dichtel
2012-10-15 15:40 ` Vlad Yasevich [this message]
2012-10-16 18:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C2E76.3030801@gmail.com \
--to=vyasevich@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=zijie.pan@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).