From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCHv3] ipv6: Enable enough of the code to handle GSO when disabled. Date: Wed, 17 Oct 2012 15:03:15 -0400 Message-ID: <507F00F3.4000305@redhat.com> References: <1350488802-24071-1-git-send-email-vyasevic@redhat.com> <1350490397.26103.647.camel@edumazet-glaptop> <1350492636.2884.5.camel@bwh-desktop.uk.solarflarecom.com> Reply-To: vyasevic@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , netdev@vger.kernel.org, davem@davemloft.net To: Ben Hutchings Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4590 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757732Ab2JQTDW (ORCPT ); Wed, 17 Oct 2012 15:03:22 -0400 In-Reply-To: <1350492636.2884.5.camel@bwh-desktop.uk.solarflarecom.com> Sender: netdev-owner@vger.kernel.org List-ID: On 10/17/2012 12:50 PM, Ben Hutchings wrote: > On Wed, 2012-10-17 at 18:13 +0200, Eric Dumazet wrote: >> On Wed, 2012-10-17 at 11:46 -0400, Vlad Yasevich wrote: >> >>> This patch attempts to solve this by enabling just enough code so GSO >>> is correctly processed. However, I should point out that if IPv6 is >>> simply blacklisted or not built for the kernel, this problem will >>> still persist. >> >> So I guess this should be done in a different way ? >> >> We currently use a single structure (struct packet_type) to hold >> pointers to different methods. (The .func() field, and the gso/gro >> stuff) >> >> We probably need to split it in two parts, and make one part linked into >> kernel, even if CONFIG_IPV6=n, so that GRO/GSO is fully IPv4/IPv6 >> functional. > [...] > > Either that or make sure that we don't advertise IPv6 GSO when IPv6 is > disabled. > > Ben. > this becomes a problem when migration or save/restore is used. since offload features may be different between systesm, we may not be able to migrate. -vlad