From: Chris Friesen <chris.friesen@genband.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Patrick McHardy <kaber@trash.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Subject: Re: Bug? TCP shutdown behaviour when deleting local IP addresses
Date: Thu, 18 Oct 2012 01:08:17 -0600 [thread overview]
Message-ID: <507FAAE1.6000903@genband.com> (raw)
In-Reply-To: <1350540348.26103.1015.camel@edumazet-glaptop>
On 10/18/2012 12:05 AM, Eric Dumazet wrote:
> On Wed, 2012-10-17 at 17:01 -0600, Chris Friesen wrote:
>> I'm seeing some unexpected (to me, at least) behaviour with local TCP
>> connections. The scenario goes as follows:
>>
>> 1) create new IP address and assign to eth device
>> 2) TCP server starts listening on that IP address
>> 3) TCP client connects to server
>> 4) remove new IP address
>> 5) kill server with ctrl-C. At this point it appears that because the
>> address was removed the shutdown message isn't processed properly.
>> netstat shows the server socket as FIN_WAIT1, but the client socket is
>> still ESTABLISHED.
>> 6) client writes to the connected socket (this passes with no error)
>> 7) client waits for response from server, and waits forever or until
>> keepalive expires
>> It seems like the waiting forever behaviour in step 7 might be
>> legitimate since the address was removed before shutting down the
>> server, but it also seems like we should be able to do better given that
>> everything is local. In the "remove IP address" case maybe step 6
>> should cause some sort of error since the IP address no longer exists?
>>
>> Incidentally, if we do this sort of scenario with the client and server
>> on different hosts then we get a "no route to host" error at step 6.
>
> I see no real problem here.
>
> Its like you cut the cable somewhere in the path.
>
> Only timeouts will apply.
While I agree generally, it's a bit unfortunate that we can't (as a
quality of implementation thing) give an earlier notice of failure since
the kernel knows about both ends of the connection even though the IP
address is gone. On the other hand, I imagine that would mean
special-casing things and presumably that would open a whole can of worms.
Thanks for the reply,
Chris
next prev parent reply other threads:[~2012-10-18 7:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 23:01 Bug? TCP shutdown behaviour when deleting local IP addresses Chris Friesen
2012-10-17 23:27 ` David Miller
2012-10-18 6:33 ` Chris Friesen
2012-10-18 6:05 ` Eric Dumazet
2012-10-18 7:08 ` Chris Friesen [this message]
2012-10-18 7:29 ` Eric Dumazet
2012-10-19 15:12 ` Chris Friesen
2012-10-19 20:43 ` Andi Kleen
2012-10-18 8:05 ` Mikael Abrahamsson
2012-10-18 9:00 ` David Laight
2012-10-18 10:00 ` Mikael Abrahamsson
2012-10-18 9:13 ` Eric Dumazet
2012-10-18 9:58 ` Mikael Abrahamsson
2012-10-18 10:01 ` Alexey Kuznetsov
2012-10-18 10:10 ` Mikael Abrahamsson
2012-10-18 10:37 ` Benny Amorsen
2012-10-18 13:00 ` Mikael Abrahamsson
2012-10-18 13:09 ` Benny Amorsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FAAE1.6000903@genband.com \
--to=chris.friesen@genband.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox