* [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers
@ 2012-10-22 0:40 Joe Jin
2012-10-22 17:17 ` Jitendra Kalsaria
2012-10-22 19:17 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Joe Jin @ 2012-10-22 0:40 UTC (permalink / raw)
To: Jitendra Kalsaria, Ron Mercer, Linux Driver, David S. Miller,
Andrew Morton
Cc: netdev, linux-kernel, Greg Marsden
Before use the request and response queue addr, make sure it has wrote
to the registers.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Cc: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index df09b1c..6407d0d 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -2525,6 +2525,13 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
qdev->req_q_size =
(u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
+ qdev->rsp_q_size = NUM_RSP_Q_ENTRIES * sizeof(struct net_rsp_iocb);
+
+ /* The barrier is required to ensure request and response queue
+ * addr writes to the registers.
+ */
+ wmb();
+
qdev->req_q_virt_addr =
pci_alloc_consistent(qdev->pdev,
(size_t) qdev->req_q_size,
@@ -2536,8 +2543,6 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
return -ENOMEM;
}
- qdev->rsp_q_size = NUM_RSP_Q_ENTRIES * sizeof(struct net_rsp_iocb);
-
qdev->rsp_q_virt_addr =
pci_alloc_consistent(qdev->pdev,
(size_t) qdev->rsp_q_size,
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers
2012-10-22 0:40 [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers Joe Jin
@ 2012-10-22 17:17 ` Jitendra Kalsaria
2012-10-22 19:17 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: Jitendra Kalsaria @ 2012-10-22 17:17 UTC (permalink / raw)
To: Joe Jin, Ron Mercer, Dept-Eng Linux Driver, David Miller,
Andrew Morton
Cc: netdev, linux-kernel, Greg Marsden
>From: Joe Jin [mailto:joe.jin@oracle.com]
>Sent: Sunday, October 21, 2012 5:41 PM
>To: Jitendra Kalsaria; Ron Mercer; Dept-Eng Linux Driver; David Miller; Andrew Morton
>Cc: netdev; linux-kernel; Greg Marsden
>Subject: [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers
>
>Before use the request and response queue addr, make sure it has wrote
>to the registers.
>
>Signed-off-by: Joe Jin <joe.jin@oracle.com>
>Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
>Cc: Ron Mercer <ron.mercer@qlogic.com>
>---
> drivers/net/ethernet/qlogic/qla3xxx.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
>index df09b1c..6407d0d 100644
>--- a/drivers/net/ethernet/qlogic/qla3xxx.c
>+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
>@@ -2525,6 +2525,13 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
> qdev->req_q_size =
> (u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
>
>+ qdev->rsp_q_size = NUM_RSP_Q_ENTRIES * sizeof(struct net_rsp_iocb);
>+
>+ /* The barrier is required to ensure request and response queue
>+ * addr writes to the registers.
>+ */
>+ wmb();
>+
> qdev->req_q_virt_addr =
> pci_alloc_consistent(qdev->pdev,
> (size_t) qdev->req_q_size,
>@@ -2536,8 +2543,6 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
> return -ENOMEM;
> }
>
>- qdev->rsp_q_size = NUM_RSP_Q_ENTRIES * sizeof(struct net_rsp_iocb);
>-
> qdev->rsp_q_virt_addr =
> pci_alloc_consistent(qdev->pdev,
> (size_t) qdev->rsp_q_size,
Acked-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
--
1.7.11.7
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers
2012-10-22 0:40 [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers Joe Jin
2012-10-22 17:17 ` Jitendra Kalsaria
@ 2012-10-22 19:17 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2012-10-22 19:17 UTC (permalink / raw)
To: joe.jin
Cc: jitendra.kalsaria, ron.mercer, Linux-Driver, akpm, netdev,
linux-kernel, greg.marsden
From: Joe Jin <joe.jin@oracle.com>
Date: Mon, 22 Oct 2012 08:40:36 +0800
> Before use the request and response queue addr, make sure it has wrote
> to the registers.
>
> Signed-off-by: Joe Jin <joe.jin@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers
@ 2012-10-19 1:24 Joe Jin
2012-10-19 17:12 ` Jitendra Kalsaria
0 siblings, 1 reply; 6+ messages in thread
From: Joe Jin @ 2012-10-19 1:24 UTC (permalink / raw)
To: Ron Mercer, Linux-Driver, Jitendra Kalsaria, Joe Jin
Cc: netdev, linux-kernel, Greg Marsden
Before use the request and response queue addr, make sure it has wrote
to the registers.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Cc: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index df09b1c..f745ade 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -2525,6 +2525,12 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
qdev->req_q_size =
(u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
+ /*
+ * The barrier is required to ensure request and response queue
+ * addr writes to the registers.
+ */
+ wmb();
+
qdev->req_q_virt_addr =
pci_alloc_consistent(qdev->pdev,
(size_t) qdev->req_q_size,
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers
2012-10-19 1:24 Joe Jin
@ 2012-10-19 17:12 ` Jitendra Kalsaria
0 siblings, 0 replies; 6+ messages in thread
From: Jitendra Kalsaria @ 2012-10-19 17:12 UTC (permalink / raw)
To: Joe Jin, Ron Mercer, Dept-Eng Linux Driver
Cc: netdev, linux-kernel, Greg Marsden
>From: Joe Jin [mailto:joe.jin@oracle.com]
>Sent: Thursday, October 18, 2012 6:25 PM
>To: Ron Mercer; Dept-Eng Linux Driver; Jitendra Kalsaria; Joe Jin
>Cc: netdev; linux-kernel; Greg Marsden
>Subject: [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers
>
>Before use the request and response queue addr, make sure it has wrote
>to the registers.
>
>Signed-off-by: Joe Jin <joe.jin@oracle.com>
>Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
>Cc: Ron Mercer <ron.mercer@qlogic.com>
>---
> drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
>index df09b1c..f745ade 100644
>--- a/drivers/net/ethernet/qlogic/qla3xxx.c
>+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
>@@ -2525,6 +2525,12 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
> qdev->req_q_size =
> (u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
>
>+ /*
>+ * The barrier is required to ensure request and response queue
>+ * addr writes to the registers.
>+ */
>+ wmb();
>+
> qdev->req_q_virt_addr =
> pci_alloc_consistent(qdev->pdev,
> (size_t) qdev->req_q_size,
Joe,
You need to move below line above the write memory barrier to get response queue address write to register
qdev->rsp_q_size = NUM_RSP_Q_ENTRIES * sizeof(struct net_rsp_iocb);
Your patch will be like below:
<snip>
qdev->req_q_size =
(u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
+ qdev->rsp_q_size = NUM_RSP_Q_ENTRIES * sizeof(struct net_rsp_iocb);
+
+ /*
+ * The barrier is required to ensure request and response queue
+ * addr writes to the registers.
+ */
+ wmb();
+
<\snip>
thanks,
Jiten
--
1.7.11.7
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers
@ 2012-10-19 1:22 Joe Jin
0 siblings, 0 replies; 6+ messages in thread
From: Joe Jin @ 2012-10-19 1:22 UTC (permalink / raw)
To: Ron Mercer, Linux-Driver, Jitendra Kalsaria, Joe Jin
Cc: netdev, linux-kernel, Greg Marsden
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
Before use the request and response queue addr, make sure it has wrote
to the registers.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Cc: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index df09b1c..f745ade 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -2525,6 +2525,12 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
qdev->req_q_size =
(u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
+ /*
+ * The barrier is required to ensure request and response queue
+ * addr writes to the registers.
+ */
+ wmb();
+
qdev->req_q_virt_addr =
pci_alloc_consistent(qdev->pdev,
(size_t) qdev->req_q_size,
--
1.7.11.7
[-- Attachment #2: Attached Message Part --]
[-- Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-22 19:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-22 0:40 [PATCH] qla3xxx: Ensure request/response queue addr writes to the registers Joe Jin
2012-10-22 17:17 ` Jitendra Kalsaria
2012-10-22 19:17 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-10-19 1:24 Joe Jin
2012-10-19 17:12 ` Jitendra Kalsaria
2012-10-19 1:22 Joe Jin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).