From: Brian Haley <brian.haley@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Pavel Emelyanov <xemul@parallels.com>,
Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] sockopt: Make SO_BINDTODEVICE readable
Date: Mon, 22 Oct 2012 17:47:54 -0400 [thread overview]
Message-ID: <5085BF0A.2030602@hp.com> (raw)
In-Reply-To: <1350941831.8609.1355.camel@edumazet-glaptop>
On 10/22/2012 05:37 PM, Eric Dumazet wrote:
> On Mon, 2012-10-22 at 17:20 -0400, Brian Haley wrote:
>
>> It's not much different from what's there:
>>
>> setsockopt("foo");
>>
>> rename foo -> bar
>>
>> index = getsockopt();
>> if_indextoname(index) -> "bar"
>>
>> I more raised the issue since you pass a 'char *' to setsockopt() but an 'int *'
>> to getsockopt(), I don't think any other value is non-symmetrical like this.
>>
>> -Brian
>
> I meant another cpu can be changing dev->name[] content while the
> strcpy() is done, and you get a mangled devname, like "for" or "bao"
> instead of "foo" or "bar"
Even when holding the rcu_read_lock()? I'd have to hold the rtnl lock there?
-Brian
next prev parent reply other threads:[~2012-10-22 21:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 9:55 [PATCH net-next] sockopt: Make SO_BINDTODEVICE readable Pavel Emelyanov
2012-10-19 10:34 ` Eric Dumazet
2012-10-22 0:43 ` David Miller
2012-10-22 10:20 ` Pavel Emelyanov
2012-10-22 18:04 ` Brian Haley
2012-10-22 20:28 ` Pavel Emelyanov
2012-10-22 21:23 ` Brian Haley
2012-10-22 20:45 ` Eric Dumazet
2012-10-22 21:10 ` Pavel Emelyanov
2012-10-22 21:20 ` Brian Haley
2012-10-22 21:37 ` Eric Dumazet
2012-10-22 21:47 ` Brian Haley [this message]
2012-10-22 21:52 ` Eric Dumazet
2012-10-22 21:58 ` Ben Hutchings
2012-10-23 21:43 ` Brian Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085BF0A.2030602@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).