From: Jan Ceuleers <jan.ceuleers@computer.org>
To: Tony Cheneau <tony.cheneau@amnesiak.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-zigbee-devel@lists.sourceforge.net,
Alan Ott <alan@signal11.us>,
Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Subject: Re: [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly
Date: Tue, 23 Oct 2012 09:04:08 +0200 [thread overview]
Message-ID: <50864168.8000509@computer.org> (raw)
In-Reply-To: <1350965397-12384-2-git-send-email-tony.cheneau@amnesiak.org>
On 10/23/2012 06:09 AM, Tony Cheneau wrote:
> #define lowpan_is_iid_16_bit_compressable(a) \
> ((((a)->s6_addr16[4]) == 0) && \
> - (((a)->s6_addr16[5]) == 0) && \
> - (((a)->s6_addr16[6]) == 0) && \
> - ((((a)->s6_addr[14]) & 0x80) == 0))
> + (((a)->s6_addr[10]) == 0) && \
> + (((a)->s6_addr[11]) == 0xff) && \
> + (((a)->s6_addr[12]) == 0xfe) && \
> + (((a)->s6_addr[13]) == 0))
> +
>
> /* multicast address */
> #define is_addr_mcast(a) (((a)->s6_addr[0]) == 0xFF)
>
Is the additional newline needed at the end of the #define?
next prev parent reply other threads:[~2012-10-23 7:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 4:09 [PATCH net-next 00/15] 6lowpan: Some more bug fixes Tony Cheneau
[not found] ` <1350965397-12384-1-git-send-email-tony.cheneau-jNfjcPZKvDhg9hUCZPvPmw@public.gmane.org>
2012-10-23 4:09 ` [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly Tony Cheneau
2012-10-23 6:49 ` David Miller
2012-10-23 14:57 ` Tony Cheneau
2012-10-23 7:04 ` Jan Ceuleers [this message]
2012-10-23 4:09 ` [PATCH net-next 02/15] 6lowpan: next header is not properly set upon decompression of a UDP header Tony Cheneau
2012-10-23 7:05 ` Jan Ceuleers
2012-10-23 4:09 ` [PATCH net-next 03/15] 6lowpan: always enable link-layer acknowledgments Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 04/15] mac802154: turn on ACK when enabled by the upper layers Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 05/15] 6lowpan: use short IEEE 802.15.4 addresses for broadcast destination Tony Cheneau
2012-10-23 7:08 ` Jan Ceuleers
2012-10-23 4:09 ` [PATCH net-next 06/15] 6lowpan: fix first fragment (FRAG1) handling Tony Cheneau
2012-10-23 7:19 ` Jan Ceuleers
2012-10-23 14:50 ` Tony Cheneau
2012-10-23 15:03 ` Eric Dumazet
2012-10-23 4:09 ` [PATCH net-next 07/15] 6lowpan: store fragment tag values per device instead of net stack wide Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 08/15] 6lowpan: obtain IEEE802.15.4 sequence number from the MAC layer Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 09/15] 6lowpan: add a new parameter in sysfs to turn on/off ACK request at " Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 10/15] 6lowpan: use the PANID provided by the device instead of a static value Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 11/15] 6lowpan: modify udp compression/uncompression to match the standard Tony Cheneau
2012-10-23 7:22 ` Jan Ceuleers
2012-10-23 4:09 ` [PATCH net-next 12/15] 6lowpan: make memory allocation atomic during 6lowpan header creation Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 13/15] mac802154: make mem alloc ATOMIC to prevent "scheduling while atomic" crashes Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 14/15] mac802154: remove unnecessary spinlocks Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 15/15] mac802154: re-introduce MAC primitives required to send/receive packets Tony Cheneau
2012-10-25 4:52 ` [PATCH net-next 00/15] 6lowpan: Some more bug fixes Alexander Smirnov
2012-10-25 14:49 ` Tony Cheneau
[not found] ` <383f66ae460548de6f930b0f1c244e5a-jNfjcPZKvDhg9hUCZPvPmw@public.gmane.org>
2012-10-25 15:10 ` Alan Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50864168.8000509@computer.org \
--to=jan.ceuleers@computer.org \
--cc=alan@signal11.us \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=tony.cheneau@amnesiak.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).