From: Duan Jiong <djduanjiong@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [PATCH] ipv6: fix the bug when propagating Redirect Message
Date: Tue, 23 Oct 2012 23:26:25 +0800 [thread overview]
Message-ID: <5086B721.1090905@gmail.com> (raw)
Before using icmpv6_notify() to propagate redirect, change skb->data
to poing the IP packet that triggered the sending of the Redirect.
Signed-off-by: Duan Jiong <djduanjiong@gmail.com>
---
net/ipv6/ndisc.c | 39 +++++++++++++++++++++++++++++++++++++++
1 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index ff36194..0f73303 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1334,6 +1334,11 @@ out:
static void ndisc_redirect_rcv(struct sk_buff *skb)
{
+ int opt_len;
+ int opt_offset;
+ int ndisc_head_len;
+ struct nd_opt_hdr *nd_opt;
+
#ifdef CONFIG_IPV6_NDISC_NODETYPE
switch (skb->ndisc_nodetype) {
case NDISC_NODETYPE_HOST:
@@ -1350,6 +1355,40 @@ static void ndisc_redirect_rcv(struct sk_buff *skb)
return;
}
+ ndisc_head_len = sizeof(struct icmp6hdr) + 2*sizeof(struct in6_addr);
+ if (!pskb_may_pull(skb, ndisc_head_len)) {
+ return;
+ }
+
+ nd_opt = (struct nd_opt_hdr *)(skb->data + ndisc_head_len);
+
+ opt_len = skb->tail - skb->transport_header - ndisc_head_len;
+ if (opt_len < 0) {
+ return;
+ }
+ while (opt_len) {
+ int l;
+
+ if (opt_len < sizeof(struct nd_opt_hdr)) {
+ return;
+ }
+ l = nd_opt->nd_opt_len << 3;
+ if (opt_len < l || l == 0) {
+ return;
+ }
+ if (nd_opt->nd_opt_type == ND_OPT_REDIRECT_HDR) {
+ __skb_pull(skb, ndisc_head_len + opt_offset + 8);
+ break;
+ }
+ opt_len -= l;
+ nd_opt = ((void *)nd_opt) + 1;
+ opt_offset += 1;
+ }
+
+ if (opt_len == 0) {
+ return;
+ }
+
icmpv6_notify(skb, NDISC_REDIRECT, 0, 0);
}
--
1.7.4.4
next reply other threads:[~2012-10-23 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 15:26 Duan Jiong [this message]
2012-10-24 4:54 ` [PATCH] ipv6: fix the bug when propagating Redirect Message Steffen Klassert
2012-11-09 8:54 ` Steffen Klassert
2012-12-11 12:58 ` Duan Jiong
2012-12-11 13:45 ` Steffen Klassert
2012-12-12 11:09 ` Duan Jiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086B721.1090905@gmail.com \
--to=djduanjiong@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).