From: Ben Greear <greearb@candelatech.com>
To: David Miller <davem@davemloft.net>
Cc: cardoe@cardoe.com, kaber@trash.net, netdev@vger.kernel.org,
systemd-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vlan: set sysfs device_type to 'vlan'
Date: Tue, 23 Oct 2012 09:14:14 -0700 [thread overview]
Message-ID: <5086C256.20202@candelatech.com> (raw)
In-Reply-To: <20121023.023647.2164665243829038911.davem@davemloft.net>
On 10/22/2012 11:36 PM, David Miller wrote:
> From: Doug Goldstein <cardoe@cardoe.com>
> Date: Mon, 22 Oct 2012 00:53:57 -0500
>
>> Sets the sysfs device_type to 'vlan' for udev. This makes it easier for
>> applications that query network information via udev to identify vlans
>> instead of using strrchr().
>>
>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>
> You're extremely misguided. This change, in fact, makes it ten times
> harder for such applications to query such devices.
If the application doesn't care, it can use the old way (which at least
for me, involves string-comparing the driver name ethtool returns, which
sucks at best).
And applications that care might suddenly have more features, or be more
efficient when running on newer kernels..
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-10-23 16:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 5:53 [PATCH] vlan: set sysfs device_type to 'vlan' Doug Goldstein
2012-10-23 6:36 ` David Miller
2012-10-23 10:34 ` Kay Sievers
2012-10-23 17:11 ` David Miller
2012-10-23 16:14 ` Ben Greear [this message]
2012-10-23 22:52 ` Ben Hutchings
2012-10-23 23:03 ` Ben Greear
2012-11-05 5:45 ` Doug Goldstein
2012-11-05 5:53 ` David Miller
2012-11-05 6:19 ` Doug Goldstein
2012-11-05 6:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086C256.20202@candelatech.com \
--to=greearb@candelatech.com \
--cc=cardoe@cardoe.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=systemd-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).