From: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
To: Tony Cheneau <tony.cheneau-jNfjcPZKvDhg9hUCZPvPmw@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH net-next 00/15] 6lowpan: Some more bug fixes
Date: Thu, 25 Oct 2012 11:10:37 -0400 [thread overview]
Message-ID: <5089566D.6000801@signal11.us> (raw)
In-Reply-To: <383f66ae460548de6f930b0f1c244e5a-jNfjcPZKvDhg9hUCZPvPmw@public.gmane.org>
On 10/25/2012 10:49 AM, Tony Cheneau wrote:
> I'm not so OK with removing patch 15, or at least, it would require
> some more testing in other parts of the code. Basically, the TBD are
> placeholder for when the Association Request/Response will be
> reimplemented. I introduced it because otherwise, .assoc_req and
> .assoc_resp entries of mac802154_mlme_wpan would go uninitialized and
> would cause kernel crash when called. I could have modified the
> calling code to deal with that, but I thought these primitives were
> meant to be re-implemented soon anyway.
I think just simply stating this in the commit message would fix the
issue here. Maybe something like "Fix crash where assoc_req() and
assoc_resp() were not defined."
This should probably get split into two patches, one for BSN and the
other for assoc.
Also, make the bsn functions static, and the convention is to put static
functions above where they are being used, so that you don't have to
forward declare them. It looks though, like this source file doesn't do
that for other functions, so maybe following the convention of this file
for now is ok.
Alan.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
prev parent reply other threads:[~2012-10-25 15:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 4:09 [PATCH net-next 00/15] 6lowpan: Some more bug fixes Tony Cheneau
[not found] ` <1350965397-12384-1-git-send-email-tony.cheneau-jNfjcPZKvDhg9hUCZPvPmw@public.gmane.org>
2012-10-23 4:09 ` [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly Tony Cheneau
2012-10-23 6:49 ` David Miller
2012-10-23 14:57 ` Tony Cheneau
2012-10-23 7:04 ` Jan Ceuleers
2012-10-23 4:09 ` [PATCH net-next 02/15] 6lowpan: next header is not properly set upon decompression of a UDP header Tony Cheneau
2012-10-23 7:05 ` Jan Ceuleers
2012-10-23 4:09 ` [PATCH net-next 03/15] 6lowpan: always enable link-layer acknowledgments Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 04/15] mac802154: turn on ACK when enabled by the upper layers Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 05/15] 6lowpan: use short IEEE 802.15.4 addresses for broadcast destination Tony Cheneau
2012-10-23 7:08 ` Jan Ceuleers
2012-10-23 4:09 ` [PATCH net-next 06/15] 6lowpan: fix first fragment (FRAG1) handling Tony Cheneau
2012-10-23 7:19 ` Jan Ceuleers
2012-10-23 14:50 ` Tony Cheneau
2012-10-23 15:03 ` Eric Dumazet
2012-10-23 4:09 ` [PATCH net-next 07/15] 6lowpan: store fragment tag values per device instead of net stack wide Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 08/15] 6lowpan: obtain IEEE802.15.4 sequence number from the MAC layer Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 09/15] 6lowpan: add a new parameter in sysfs to turn on/off ACK request at " Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 10/15] 6lowpan: use the PANID provided by the device instead of a static value Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 11/15] 6lowpan: modify udp compression/uncompression to match the standard Tony Cheneau
2012-10-23 7:22 ` Jan Ceuleers
2012-10-23 4:09 ` [PATCH net-next 12/15] 6lowpan: make memory allocation atomic during 6lowpan header creation Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 13/15] mac802154: make mem alloc ATOMIC to prevent "scheduling while atomic" crashes Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 14/15] mac802154: remove unnecessary spinlocks Tony Cheneau
2012-10-23 4:09 ` [PATCH net-next 15/15] mac802154: re-introduce MAC primitives required to send/receive packets Tony Cheneau
2012-10-25 4:52 ` [PATCH net-next 00/15] 6lowpan: Some more bug fixes Alexander Smirnov
2012-10-25 14:49 ` Tony Cheneau
[not found] ` <383f66ae460548de6f930b0f1c244e5a-jNfjcPZKvDhg9hUCZPvPmw@public.gmane.org>
2012-10-25 15:10 ` Alan Ott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5089566D.6000801@signal11.us \
--to=alan-yzvjwurpmd1zbrfiqnyvsa@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tony.cheneau-jNfjcPZKvDhg9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).