From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
netdev@vger.kernel.org, linaro-dev@lists.linaro.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
patches@linaro.org
Subject: Re: [PATCH] net: dsa/slave: Fix compilation warnings
Date: Tue, 30 Oct 2012 10:26:52 +0100 [thread overview]
Message-ID: <508F9D5C.2020802@linaro.org> (raw)
In-Reply-To: <CAKohpon8C5O4U+h3nr=8gaEQ1f-K9pqafw=5jPrhaGup_3re=g@mail.gmail.com>
On 10/30/2012 10:03 AM, Viresh Kumar wrote:
> On 30 October 2012 14:30, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>> It is very curious if we disable all the configs option, a slave
>> creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA
>> enabled and none of the NET_DSA_TAG* enabled will raise a BUG in the
>> probe function, right ?
>>
>> Maybe we should force at least one config when none are set ?
>
> I thought of it earlier. But found the one which i posted better. As we will not
> compile DSA stuff now without these tags.
Well, it is the same here, no ? Except, it is up to the user to disable
the option.
>
> --
> viresh
>
>> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
>> index 274791c..86326e3 100644
>> --- a/net/dsa/Kconfig
>> +++ b/net/dsa/Kconfig
>> @@ -1,8 +1,9 @@
>> -config NET_DSA
>> +menuconfig NET_DSA
>> tristate "Distributed Switch Architecture support"
>> default n
>> depends on EXPERIMENTAL && NETDEVICES && !S390
>> select PHYLIB
>> + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA &&
>> !NET_DSA_TAG_TRAILER)
>> ---help---
>> This allows you to use hardware switch chips that use
>> the Distributed Switch Architecture.
>> @@ -12,15 +13,15 @@ if NET_DSA
>>
>> # tagging formats
>> config NET_DSA_TAG_DSA
>> - bool
>> + bool "tag dsa"
>> default n
>>
>> config NET_DSA_TAG_EDSA
>> - bool
>> + bool "tag edsa"
>> default n
>>
>> config NET_DSA_TAG_TRAILER
>> - bool
>> + bool "tag trailer"
>> default n
>>
>> endif
>>
>>
>> --
>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>>
>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>> <http://twitter.com/#!/linaroorg> Twitter |
>> <http://www.linaro.org/linaro-blog/> Blog
>>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2012-10-30 9:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 16:57 [PATCH] net: dsa/slave: Fix compilation warnings Viresh Kumar
2012-10-29 19:59 ` Ben Hutchings
2012-10-30 6:45 ` Viresh Kumar
2012-10-30 7:31 ` Viresh Kumar
2012-10-30 7:53 ` Daniel Lezcano
2012-10-30 7:55 ` Viresh Kumar
2012-10-30 9:00 ` Daniel Lezcano
2012-10-30 9:03 ` Viresh Kumar
2012-10-30 9:26 ` Daniel Lezcano [this message]
2012-10-30 9:45 ` Viresh Kumar
2012-10-30 10:04 ` Daniel Lezcano
[not found] ` <CAKohponOKk5e2Sxyhjw-XvzVxF3tNp66rsnYCwvwHazAPAauKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-07 3:50 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508F9D5C.2020802@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=patches@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).