From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] net: dsa/slave: Fix compilation warnings Date: Tue, 30 Oct 2012 11:04:57 +0100 Message-ID: <508FA649.6090901@linaro.org> References: <5afab1ebe83e4361f1fd75bbea0c559af195bf02.1351529738.git.viresh.kumar@linaro.org> <1351540778.2721.7.camel@bwh-desktop.uk.solarflarecom.com> <508F8779.8070300@linaro.org> <508F9724.50804@linaro.org> <508F9D5C.2020802@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ben Hutchings , netdev@vger.kernel.org, linaro-dev@lists.linaro.org, davem@davemloft.net, linux-kernel@vger.kernel.org, patches@linaro.org To: Viresh Kumar Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/30/2012 10:45 AM, Viresh Kumar wrote: > On 30 October 2012 14:56, Daniel Lezcano = wrote: >> Well, it is the same here, no ? Except, it is up to the user to disa= ble >> the option. >=20 > I didn't wanted to add code like this: >=20 >>> + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA && >>> !NET_DSA_TAG_TRAILER) >=20 > Why should we select NET_DSA_TAG_DSA by default? What made us > select that? That was an example, like you I don't know the DSA at all. I guess the maintainer will guide on that. > For this reason, i went to the solution i offered. Ok. > Anyway, i just wanted to get rid of the warning. Whatever maintainer > feels is better must be selected. Yep. -- Daniel --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog