From: Chen Gang <gang.chen@asianux.com>
To: David Miller <davem@davemloft.net>,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net
Cc: netdev <netdev@vger.kernel.org>
Subject: [PATCH] driver: net: ppp: change 8% to %s for seq_printf of pppoe_seq_show
Date: Mon, 05 Nov 2012 19:31:27 +0800 [thread overview]
Message-ID: <5097A38F.2000003@asianux.com> (raw)
the length of po->pppoe_pa.dev is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for po->pppoe_pa.dev.
so change it to %s, since each line has not been solid any more.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/net/ppp/pppoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index 20f31d0..7e89710 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -1009,7 +1009,7 @@ static int pppoe_seq_show(struct seq_file *seq,
void *v)
po = v;
dev_name = po->pppoe_pa.dev;
- seq_printf(seq, "%08X %pM %8s\n",
+ seq_printf(seq, "%08X %pM %s\n",
po->pppoe_pa.sid, po->pppoe_pa.remote, dev_name);
out:
return 0;
--
1.7.9.5
reply other threads:[~2012-11-05 11:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5097A38F.2000003@asianux.com \
--to=gang.chen@asianux.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox