* ping -f is broken in iputils 20121011
@ 2012-10-30 20:52 Mohammad Alsaleh
0 siblings, 0 replies; 6+ messages in thread
From: Mohammad Alsaleh @ 2012-10-30 20:52 UTC (permalink / raw)
To: netdev
As explained in this bug report(1). ping -f seems to be broken in
iputils 20121011.
(1) https://bugs.archlinux.org/task/32306
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ping -f is broken in iputils 20121011
[not found] <20121030205249.GA2817@mail>
@ 2012-10-31 9:11 ` Mohammad Alsaleh
2012-11-05 9:17 ` Jan Synacek
0 siblings, 1 reply; 6+ messages in thread
From: Mohammad Alsaleh @ 2012-10-31 9:11 UTC (permalink / raw)
To: netdev
On Tue, Oct 30, 2012 at 11:52:49PM +0300, Mohammad Alsaleh wrote:
> As explained in this bug report(1). ping -f seems to be broken in
> iputils 20121011.
>
> (1) https://bugs.archlinux.org/task/32306
Bisected to commit 8feb586c4c6df32badb159947ed233898891aecd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ping -f is broken in iputils 20121011
2012-10-31 9:11 ` ping -f is broken in iputils 20121011 Mohammad Alsaleh
@ 2012-11-05 9:17 ` Jan Synacek
2012-11-05 15:37 ` Mohammad Alsaleh
2012-11-05 18:12 ` YOSHIFUJI Hideaki
0 siblings, 2 replies; 6+ messages in thread
From: Jan Synacek @ 2012-11-05 9:17 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
On 10/31/2012 10:11 AM, Mohammad Alsaleh wrote:
> On Tue, Oct 30, 2012 at 11:52:49PM +0300, Mohammad Alsaleh wrote:
>> As explained in this bug report(1). ping -f seems to be broken in
>> iputils 20121011.
>>
>> (1) https://bugs.archlinux.org/task/32306
>
> Bisected to commit 8feb586c4c6df32badb159947ed233898891aecd
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Can you please try the attached patch?
--
Jan Synacek
Software Engineer, BaseOS team Brno, Red Hat
[-- Attachment #2: flood.patch --]
[-- Type: text/x-patch, Size: 676 bytes --]
--- iputils-s20121011/ping_common.h 2012-11-05 10:07:40.065281888 +0100
+++ iputils-s20121011-new/ping_common.h 2012-11-05 10:07:22.001268362 +0100
@@ -141,7 +141,7 @@ static inline void write_stdout(const ch
do {
cc = write(STDOUT_FILENO, str + o, len - o);
o += cc;
- } while (len >= o || cc < 0);
+ } while (len > o || cc < 0);
}
/*
--- iputils-s20121011/ping_common.c 2012-11-05 10:07:40.066281889 +0100
+++ iputils-s20121011-new/ping_common.c 2012-11-05 10:07:22.007268368 +0100
@@ -776,7 +776,7 @@ restamp:
if (!csfailed)
write_stdout("\b \b", 3);
else
- write_stdout("\bC", 1);
+ write_stdout("\bC", 2);
} else {
int i;
__u8 *cp, *dp;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ping -f is broken in iputils 20121011
@ 2012-11-05 15:28 Stéphane Gaudreault
0 siblings, 0 replies; 6+ messages in thread
From: Stéphane Gaudreault @ 2012-11-05 15:28 UTC (permalink / raw)
To: netdev
The patch proposed by Jan Synacek worked to me.
Sorry for not replying to his message, I just subscribed to this ML.
Cheers,
--
Stéphane Gaudreault
Arch Linux developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ping -f is broken in iputils 20121011
2012-11-05 9:17 ` Jan Synacek
@ 2012-11-05 15:37 ` Mohammad Alsaleh
2012-11-05 18:12 ` YOSHIFUJI Hideaki
1 sibling, 0 replies; 6+ messages in thread
From: Mohammad Alsaleh @ 2012-11-05 15:37 UTC (permalink / raw)
To: netdev; +Cc: Jan Synacek
>On 10/31/2012 10:11 AM, Mohammad Alsaleh wrote:
>> On Tue, Oct 30, 2012 at 11:52:49PM +0300, Mohammad Alsaleh wrote:
>>> As explained in this bug report(1). ping -f seems to be broken in
>>> iputils 20121011.
>>>
>>> (1) https://bugs.archlinux.org/task/32306
>>
>> Bisected to commit 8feb586c4c6df32badb159947ed233898891aecd
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>Can you please try the attached patch?
>
>--
>Jan Synacek
>Software Engineer, BaseOS team Brno, Red Hat
>
>--- iputils-s20121011/ping_common.h 2012-11-05 10:07:40.065281888
>+0100
>+++ iputils-s20121011-new/ping_common.h 2012-11-05 10:07:22.001268362
>+0100
>@@ -141,7 +141,7 @@ static inline void write_stdout(const ch
> do {
> cc = write(STDOUT_FILENO, str + o, len - o);
> o += cc;
>- } while (len >= o || cc < 0);
>+ } while (len > o || cc < 0);
> }
>
> /*
>--- iputils-s20121011/ping_common.c 2012-11-05 10:07:40.066281889
>+0100
>+++ iputils-s20121011-new/ping_common.c 2012-11-05 10:07:22.007268368
>+0100
>@@ -776,7 +776,7 @@ restamp:
> if (!csfailed)
> write_stdout("\b \b", 3);
> else
>- write_stdout("\bC", 1);
>+ write_stdout("\bC", 2);
> } else {
> int i;
> __u8 *cp, *dp;
>
Sorry if this reply does not appear in the right thread. I'm not
subscribed to the list.
I can confirm the patch fixes the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ping -f is broken in iputils 20121011
2012-11-05 9:17 ` Jan Synacek
2012-11-05 15:37 ` Mohammad Alsaleh
@ 2012-11-05 18:12 ` YOSHIFUJI Hideaki
1 sibling, 0 replies; 6+ messages in thread
From: YOSHIFUJI Hideaki @ 2012-11-05 18:12 UTC (permalink / raw)
To: Jan Synacek, msal; +Cc: netdev, YOSHIFUJI Hideaki
Hi,
Jan Synacek wrote:
> On 10/31/2012 10:11 AM, Mohammad Alsaleh wrote:
>> On Tue, Oct 30, 2012 at 11:52:49PM +0300, Mohammad Alsaleh wrote:
>>> As explained in this bug report(1). ping -f seems to be broken in
>>> iputils 20121011.
>>>
>>> (1) https://bugs.archlinux.org/task/32306
>>
>> Bisected to commit 8feb586c4c6df32badb159947ed233898891aecd
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> Can you please try the attached patch?
>
I applied this patch. Thank you.
Mohammad, Thank you for spotting this.
--yoshfuji
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-05 18:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20121030205249.GA2817@mail>
2012-10-31 9:11 ` ping -f is broken in iputils 20121011 Mohammad Alsaleh
2012-11-05 9:17 ` Jan Synacek
2012-11-05 15:37 ` Mohammad Alsaleh
2012-11-05 18:12 ` YOSHIFUJI Hideaki
2012-11-05 15:28 Stéphane Gaudreault
-- strict thread matches above, loose matches on Subject: below --
2012-10-30 20:52 Mohammad Alsaleh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).