From: Shan Wei <shanwei88-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
NetDev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Kernel-Maillist
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper
Date: Thu, 08 Nov 2012 22:22:30 +0800 [thread overview]
Message-ID: <509BC026.4040209@gmail.com> (raw)
In-Reply-To: <0000013ac23ac528-19a0dd1b-3144-45df-9d6e-471999d6ae31-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
Christoph Lameter said, at 2012/11/3 1:46:
>> u64_stats_update_begin(&stats->sync);
>> stats->tx_packets++;
>
> Use this_cpu_inc(vport->percpu_stats->packets) here?
Lots of network drivers use u64_stats_sync infrastructure for statistics
on 32bit or 64bit hosts no matter how many members in per-cpu variable.
keep them be consistent, so no plan to change them.
Thanks
next prev parent reply other threads:[~2012-11-08 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 16:01 [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper Shan Wei
[not found] ` <5093EE59.8010609-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-02 17:46 ` Christoph Lameter
[not found] ` <0000013ac23ac528-19a0dd1b-3144-45df-9d6e-471999d6ae31-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-11-08 14:22 ` Shan Wei [this message]
[not found] ` <509BC026.4040209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-08 17:18 ` Christoph Lameter
[not found] ` <0000013ae10817d9-c5215352-348f-4898-b618-bb89e8725ab1-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-11-09 1:39 ` Shan Wei
-- strict thread matches above, loose matches on Subject: below --
2012-10-31 11:22 Shan Wei
[not found] ` <50910A04.5000003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-31 17:39 ` Christoph Lameter
[not found] ` <0000013ab7e86f8a-4adb8b81-19be-4264-96f1-924aaf3819f2-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-11-01 10:07 ` Shan Wei
[not found] ` <509249C7.3080000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-01 14:33 ` Christoph Lameter
[not found] ` <0000013abc646055-30441bd6-241f-436a-a356-9cd462da66ce-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-11-01 14:44 ` 单卫
2012-11-02 1:38 ` Jesse Gross
[not found] ` <CAEP_g=-GSpSJkeZbwDpBwo-in0FYD=LjWdCFsdo7-a=ssL41nA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-02 14:01 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509BC026.4040209@gmail.com \
--to=shanwei88-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).