From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Mallon Subject: Re: [PATCH] vmxnet3: convert BUG_ON(true) into a simple BUG() Date: Mon, 12 Nov 2012 09:27:39 +1100 Message-ID: <50A0265B.8040209@gmail.com> References: <1352406191-14303-1-git-send-email-sasha.levin@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Shreyas Bhatewara , "VMware, Inc." , netdev@vger.kernel.org To: Sasha Levin Return-path: In-Reply-To: <1352406191-14303-1-git-send-email-sasha.levin@oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/11/12 07:23, Sasha Levin wrote: > Signed-off-by: Sasha Levin > --- > drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c > index 0ae1bcc..7e9622f 100644 > --- a/drivers/net/vmxnet3/vmxnet3_drv.c > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c > @@ -1922,7 +1922,7 @@ vmxnet3_free_irqs(struct vmxnet3_adapter *adapter) > free_irq(adapter->pdev->irq, adapter->netdev); > break; > default: > - BUG_ON(true); > + BUG(); > } > } All of the BUG_ON tests in this function look like programming error assertions. It looks like the worst that would happen is that some irqs might not be properly released, not the sort of thing that is going to make the system unstable if you don't bug. Can't they just be replaced with (for example): if (WARN_ON(blah)) return; Or even just: netdev_err(adapter->netdev, "bad irq type %d for free\n", intr->type); ~Ryan