From: John Fastabend <john.r.fastabend@intel.com>
To: Michael Chan <mchan@broadcom.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] 8021q: validate SAN MAC address
Date: Tue, 13 Nov 2012 17:58:16 -0800 [thread overview]
Message-ID: <50A2FAB8.8010803@intel.com> (raw)
In-Reply-To: <1352857850.6276.71.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
On 11/13/2012 5:50 PM, Michael Chan wrote:
> On Tue, 2012-11-13 at 20:24 -0500, David Miller wrote:
>> From: "Michael Chan" <mchan@broadcom.com>
>> Date: Tue, 13 Nov 2012 15:40:29 -0800
>>
>>> I suppose we can just put the SAN MAC into the real netdev->dev_addr so
>>> that the VLAN will automatically get it. But this doesn't seem very
>>> nice as we would be pretending to have a normal MAC address (for
>>> networking) in this SAN device. The networking MAC address is in a
>>> different PCI function.
>>
>> I certainly would prefer if you took that approach. At least in that
>> way the addressing of the netdev objects would appear more consistent.
>>
> Ok. To be more complete, I think we need to add a flag or something to
> such a netdev to indicate that it is a SAN device only. What's your
> opinion on that?
Michael, how do you determine a L2 packet is a SAN type? Do you have
ACLs in the FW/hardware to prevent other types of L2 traffic from being
sent? I guess I'm asking what makes it a SAN only device.
.John
next prev parent reply other threads:[~2012-11-14 1:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 22:54 [PATCH net-next] 8021q: validate SAN MAC address Michael Chan
2012-11-09 23:02 ` Ben Hutchings
2012-11-10 0:25 ` Michael Chan
2012-11-10 0:36 ` Ben Hutchings
2012-11-10 0:44 ` Michael Chan
2012-11-13 21:53 ` David Miller
2012-11-13 22:29 ` Michael Chan
2012-11-13 23:16 ` David Miller
2012-11-13 23:40 ` Michael Chan
2012-11-14 1:24 ` David Miller
2012-11-14 1:50 ` Michael Chan
2012-11-14 1:58 ` John Fastabend [this message]
2012-11-14 2:41 ` Michael Chan
2012-11-14 1:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A2FAB8.8010803@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).