* [PATCH 8/8] drivers/net/wireless/ath/ath6kl/hif.c: drop if around WARN_ON [not found] <1351974625-10282-1-git-send-email-Julia.Lawall@lip6.fr> @ 2012-11-03 20:30 ` Julia Lawall [not found] ` <1351974625-10282-9-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Julia Lawall @ 2012-11-03 20:30 UTC (permalink / raw) To: Kalle Valo Cc: kernel-janitors, John W. Linville, linux-wireless, netdev, linux-kernel From: Julia Lawall <Julia.Lawall@lip6.fr> Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e; @@ - if (e) WARN_ON(1); + WARN_ON(e); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/net/wireless/ath/ath6kl/hif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c index 68ed6c2..9e47c4a 100644 --- a/drivers/net/wireless/ath/ath6kl/hif.c +++ b/drivers/net/wireless/ath/ath6kl/hif.c @@ -338,8 +338,7 @@ static int ath6kl_hif_proc_err_intr(struct ath6kl_device *dev) status = hif_read_write_sync(dev->ar, ERROR_INT_STATUS_ADDRESS, reg_buf, 4, HIF_WR_SYNC_BYTE_FIX); - if (status) - WARN_ON(1); + WARN_ON(status); return status; } @@ -383,8 +382,7 @@ static int ath6kl_hif_proc_cpu_intr(struct ath6kl_device *dev) status = hif_read_write_sync(dev->ar, CPU_INT_STATUS_ADDRESS, reg_buf, 4, HIF_WR_SYNC_BYTE_FIX); - if (status) - WARN_ON(1); + WARN_ON(status); return status; } ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <1351974625-10282-9-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>]
* Re: [PATCH 8/8] drivers/net/wireless/ath/ath6kl/hif.c: drop if around WARN_ON [not found] ` <1351974625-10282-9-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org> @ 2012-11-16 11:39 ` Kalle Valo 0 siblings, 0 replies; 2+ messages in thread From: Kalle Valo @ 2012-11-16 11:39 UTC (permalink / raw) To: Julia Lawall Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA, John W. Linville, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 11/03/2012 10:30 PM, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org> > > Just use WARN_ON rather than an if containing only WARN_ON(1). > > A simplified version of the semantic patch that makes this transformation > is as follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e; > @@ > - if (e) WARN_ON(1); > + WARN_ON(e); > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org> Thanks, applied to ath6kl.git. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-16 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1351974625-10282-1-git-send-email-Julia.Lawall@lip6.fr>
2012-11-03 20:30 ` [PATCH 8/8] drivers/net/wireless/ath/ath6kl/hif.c: drop if around WARN_ON Julia Lawall
[not found] ` <1351974625-10282-9-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2012-11-16 11:39 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).