From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH net-next] pch_gbe, ptp_pch: Fix the dependency direction between these drivers Date: Fri, 16 Nov 2012 18:02:04 -0800 Message-ID: <50A6F01C.4010304@xenotime.net> References: <1353116639.2743.88.camel@bwh-desktop.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, Randy Dunlap , Takahiro Shimizu , Richard Cochran To: Ben Hutchings Return-path: Received: from 173-254-64-10.unifiedlayer.com ([173.254.64.10]:40692 "HELO oproxy11-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753101Ab2KQCCt (ORCPT ); Fri, 16 Nov 2012 21:02:49 -0500 In-Reply-To: <1353116639.2743.88.camel@bwh-desktop.uk.solarflarecom.com> Sender: netdev-owner@vger.kernel.org List-ID: On 11/16/2012 05:43 PM, Ben Hutchings wrote: > In commit a24006ed12616bde1bbdb26868495906a212d8dc ('ptp: Enable clock > drivers along with associated net/PHY drivers') I wrongly made > PTP_1588_CLOCK_PCH depend on PCH_GBE. The dependency is really the > other way around. Therefore make PCH_GBE select PTP_1588_CLOCK_PCH > and remove the 'default y' from the latter. > > Reported-by: Randy Dunlap > Signed-off-by: Ben Hutchings Acked-by: Randy Dunlap Thanks. > --- > drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 1 + > drivers/ptp/Kconfig | 2 -- > 2 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig > index 00bc4fc..34d05bf 100644 > --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig > @@ -7,6 +7,7 @@ config PCH_GBE > depends on PCI > select NET_CORE > select MII > + select PTP_1588_CLOCK_PCH > ---help--- > This is a gigabit ethernet driver for EG20T PCH. > EG20T PCH is the platform controller hub that is used in Intel's > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig > index 70c5836..1ea6f1d 100644 > --- a/drivers/ptp/Kconfig > +++ b/drivers/ptp/Kconfig > @@ -72,9 +72,7 @@ config DP83640_PHY > > config PTP_1588_CLOCK_PCH > tristate "Intel PCH EG20T as PTP clock" > - depends on PCH_GBE > select PTP_1588_CLOCK > - default y > help > This driver adds support for using the PCH EG20T as a PTP > clock. The hardware supports time stamping of PTP packets -- ~Randy