From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] ipip: allow to deactivate the creation of fb dev
Date: Tue, 20 Nov 2012 09:30:17 +0100 [thread overview]
Message-ID: <50AB3F99.7070701@6wind.com> (raw)
In-Reply-To: <20121119.190753.856116050444408241.davem@davemloft.net>
Le 20/11/2012 01:07, David Miller a écrit :
> From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Date: Fri, 16 Nov 2012 17:46:11 +0100
>
>> By default, the fb device is created, so there is no change if you
>> don't set explicitly setup_fb to 0.
>
>
> Nicolas, this idea is contentous to me too.
>
> Why not put this aside and submit the other parts of your
> patch set on their own, since those looked fine to me?
Ok, no problem. I wanted to get feedback about this kind of idea, I understand
the point.
When you said "the other parts", you mean only patch 2/4 (sit: allow to
configure 6rd tunnels via netlink) or 3/4 and 4/4 too?
Because 3/4 and 4/4 are equivalent to this one.
next prev parent reply other threads:[~2012-11-20 8:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 16:14 [PATCH net-next 0/4] Allow to deactivate fb tunnels device Nicolas Dichtel
2012-11-16 16:14 ` [PATCH net-next 1/4] ipip: allow to deactivate the creation of fb dev Nicolas Dichtel
2012-11-16 16:29 ` Stephen Hemminger
2012-11-16 16:46 ` Nicolas Dichtel
2012-11-20 0:07 ` David Miller
2012-11-20 8:30 ` Nicolas Dichtel [this message]
2012-11-20 8:34 ` David Miller
2012-11-20 8:41 ` [RESEND PATCH net-next 1/1] sit: allow to configure 6rd tunnels via netlink Nicolas Dichtel
2012-11-20 17:01 ` Stephen Hemminger
2012-11-20 17:11 ` Nicolas Dichtel
2012-11-20 17:17 ` Stephen Hemminger
2012-11-20 17:22 ` Nicolas Dichtel
2012-11-20 18:45 ` David Miller
2012-11-20 0:06 ` [PATCH net-next 1/4] ipip: allow to deactivate the creation of fb dev David Miller
2012-11-16 16:14 ` [PATCH net-next 2/4] sit: allow to configure 6rd tunnels via netlink Nicolas Dichtel
2012-11-16 16:14 ` [PATCH net-next 3/4] sit: allow to deactivate the creation of fb device Nicolas Dichtel
2012-11-16 16:14 ` [PATCH net-next 4/4] ip6tnl: allow to deactivate the creation of fb dev Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB3F99.7070701@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).