netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Bader <stefan.bader@canonical.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: ANNIE LI <annie.li@oracle.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Marcos E. Matsunaga" <Marcos.Matsunaga@oracle.com>,
	xen-devel <xen-devel@lists.xen.org>,
	Konrad Rzeszutek Wilk <konrad@kernel.org>,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [Xen-devel] compound skb frag pages appearing in start_xmit
Date: Tue, 20 Nov 2012 09:30:21 +0100	[thread overview]
Message-ID: <50AB3F9D.4070905@canonical.com> (raw)
In-Reply-To: <1333495676.20121119164304@eikelenboom.it>

[-- Attachment #1: Type: text/plain, Size: 2248 bytes --]

On 19.11.2012 16:43, Sander Eikelenboom wrote:
> 
> Thursday, November 15, 2012, 3:31:42 AM, you wrote:
> 
>> On 2012-10-11 18:14, Ian Campbell wrote:
>>> On Thu, 2012-10-11 at 11:05 +0100, Eric Dumazet wrote:
>>>> On Thu, 2012-10-11 at 12:00 +0200, Sander Eikelenboom wrote:
>>>>
>>>>> Probably due to the BUG_ON from the patch below, i changed it into a WARN_ON.
>>>>> And i seem to hit it, but only in one of the guests at the moment and it triggers quite irregularly.
>>>> xennet_make_frags() is able to split the skb->head in multiple page-size
>>>> chunks.
>>>>
>>>> It should do the same for fragments
>>> Right, I just want to be reproduce the issue so I can know I've fixed it
>>> properly ;-)
>> Hi Ian,
> 
>> I can reproduce this BUG_ON when running netperf/netserver test between 
>> two domus running on the same dom0. The domu and dom0 all use v3.7-rc1.
> 
>> When I tried to rebase my persistent grant netfront/netback patch on 
>> latest kernel, netperf/netserver test never succeeded. I did some test 
>> to find out that v3.6-rc7 works fine, but v3.7-rc1, v3.7-rc2 and 
>> v3.7-rc4 does not succeed in netperf/netserver test. So I keep my 
>> persistent grant patch only based on v3.4-rc3 now.
> 
>> Konrad thought about commit 6a8ed462f16b8455eec5ae00eb6014159a6721f0 in 
>> v3.7-rc1, and suggested me to test your debug patch in netfront. This 
>> BUG_ON happens soon after running the netperf/netserver test case.
> 
>> Thanks
>> Annie
> 
> Is there any progression with this bug (rc6 is out the door, so the release of 3.7-final seems to be eminent and this bug completely cripples any networking with guests) ?
> 

+1 on that. I was testing yesterday with a PVM domU running 3.7-rc5 on Xen 4.2
(but also reported from EC2 running Xen 3.4.3) c with one VCPU. I actually can
trigger it by just ssh'ing into the domU (from another machine) and then run
"find /". Output starts to stutter and then stops completely. When this happens
a new connection still can be made and as long as only shorter output is
generated the ssh connection is ok. From a dump taken it looks like user-space
is waiting in some select call (without any warnon I rather won't see the tx path).

-Stefan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]

  reply	other threads:[~2012-11-20  8:30 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09 13:47 compound skb frag pages appearing in start_xmit Ian Campbell
2012-10-09 13:54 ` Eric Dumazet
2012-10-09 14:01   ` Eric Dumazet
2012-10-09 14:23     ` Ian Campbell
2012-10-09 14:33       ` Eric Dumazet
2012-10-09 14:54         ` Ian Campbell
2012-10-09 14:17   ` Ian Campbell
2012-10-09 14:27     ` Eric Dumazet
2012-10-09 14:40       ` Ian Campbell
2012-10-09 14:51         ` Eric Dumazet
2012-10-10 10:13         ` [Xen-devel] " Ian Campbell
2012-10-10 12:24           ` Sander Eikelenboom
2012-10-10 12:29             ` [Xen-devel] " Ian Campbell
2012-10-10 13:31               ` Sander Eikelenboom
2012-10-10 13:09           ` Ian Campbell
2012-10-10 14:49             ` Sander Eikelenboom
2012-10-11  8:02               ` Ian Campbell
2012-10-11 10:00                 ` Sander Eikelenboom
2012-10-11 10:05                   ` Eric Dumazet
2012-10-11 10:14                     ` Ian Campbell
2012-10-11 10:20                       ` Sander Eikelenboom
2012-11-15  2:31                       ` ANNIE LI
2012-11-19 15:43                         ` Sander Eikelenboom
2012-11-20  8:30                           ` Stefan Bader [this message]
2012-11-20  9:21                             ` Ian Campbell
2012-11-20 11:36                               ` [Xen-devel] " Ian Campbell
2012-11-21  2:42                                 ` ANNIE LI
2012-11-20 11:40                               ` [PATCH] xen/netfront: handle compound page fragments on transmit Ian Campbell
2012-11-20 12:28                                 ` [Xen-devel] " Jan Beulich
2012-11-20 13:35                                   ` Ian Campbell
2012-11-20 13:51                                     ` Jan Beulich
2012-11-20 14:14                                       ` Ian Campbell
2012-11-20 14:32                                         ` Jan Beulich
2012-11-20 15:06                                           ` Ian Campbell
2012-11-20 15:28                                             ` Eric Dumazet
2012-11-20 15:54                                               ` Ian Campbell
2012-11-20 15:44                                             ` Jan Beulich
2012-11-20 16:14                                               ` Eric Dumazet
2012-11-20 13:30                                 ` Stefan Bader
2012-11-20 13:45                                   ` Sander Eikelenboom
2012-11-20 14:45                                 ` Eric Dumazet
2012-11-20 15:05                                   ` Ian Campbell
2012-11-21  2:52                                 ` ANNIE LI
2012-11-21 11:09                                   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AB3F9D.4070905@canonical.com \
    --to=stefan.bader@canonical.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Marcos.Matsunaga@oracle.com \
    --cc=annie.li@oracle.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=konrad@kernel.org \
    --cc=linux@eikelenboom.it \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).