From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCH 1/7] netcls_cgroup: move config inheritance to ->css_online() and remove .broken_hierarchy marking Date: Tue, 20 Nov 2012 09:35:59 +0100 Message-ID: <50AB40EF.8050304@monom.org> References: <1353400211-5182-1-git-send-email-tj@kernel.org> <1353400211-5182-2-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, tgraf-G/eBtMaohhA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: Tejun Heo Return-path: In-Reply-To: <1353400211-5182-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org On 20.11.2012 09:30, Tejun Heo wrote: > It turns out that we'll have to live with attributes which are > inherited at cgroup creation time but not affected by further updates > to the parent afterwards - such attributes are already in wide use > e.g. for cpuset. > > So, there's nothing to do for netcls_cgroup for hierarchy support. > Its current behavior - inherit only during creation - is good enough. > > Move config inheriting from ->css_alloc() to ->css_online() for > consistency, which doesn't change behavior at all, and remove > .broken_hierarchy marking. > > Signed-off-by: Tejun Heo Not introducing the 'is_local' is a good thing. Tested and Acked-by: Daniel Wagner