From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCH 5/7] netprio_cgroup: use cgroup->id instead of cgroup_netprio_state->prioidx Date: Tue, 20 Nov 2012 09:47:24 +0100 Message-ID: <50AB439C.4090703@monom.org> References: <1353400211-5182-1-git-send-email-tj@kernel.org> <1353400211-5182-6-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, tgraf-G/eBtMaohhA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: Tejun Heo Return-path: In-Reply-To: <1353400211-5182-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org On 20.11.2012 09:30, Tejun Heo wrote: > With priomap expansion no longer depending on knowing max id > allocated, netprio_cgroup can use cgroup->id insted of cs->prioidx. > Drop prioidx alloc/free logic and convert all uses to cgroup->id. > > * In cgrp_css_alloc(), parent->id test is moved above @cs allocation > to simplify error path. > > * In cgrp_css_free(), @cs assignment is made initialization. > > Signed-off-by: Tejun Heo > Acked-by: Neil Horman Tested and Acked-by: Daniel Wagner