netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Einar Lueck <elelueck@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, frankbla@de.ibm.com, raspl@de.ibm.com,
	ubacher@de.ibm.com, samudrala@us.ibm.com
Subject: Re: [RFC PATCH] tcp: introduce raw access to experimental options
Date: Wed, 21 Nov 2012 15:26:30 +0100	[thread overview]
Message-ID: <50ACE496.20705@linux.vnet.ibm.com> (raw)
In-Reply-To: <20121116.134424.1929556546744828875.davem@davemloft.net>

On 11/16/2012 07:44 PM, David Miller wrote:
>
> Unprivileged access to set and fetch these things?  I don't think
> that's a good idea.
>
> Also, your code has a lot of coding style errors.
>

Would a restriction to a CAP_NET_ADMIN like privilege level address and 
resolve your concerns?

Thx,
Einar.

  reply	other threads:[~2012-11-21 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 16:54 [RFC PATCH] tcp: introduce raw access to experimental options elelueck
2012-11-16 18:44 ` David Miller
2012-11-21 14:26   ` Einar Lueck [this message]
2012-11-28 10:12     ` Einar Lueck
2012-11-28 12:01 ` Yuchung Cheng
2012-12-03 18:44   ` Einar Lueck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ACE496.20705@linux.vnet.ibm.com \
    --to=elelueck@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=frankbla@de.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=raspl@de.ibm.com \
    --cc=samudrala@us.ibm.com \
    --cc=ubacher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).