From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shan Wei Subject: Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route Date: Thu, 22 Nov 2012 13:28:07 +0800 Message-ID: <50ADB7E7.1000009@gmail.com> References: <50AD9351.5020805@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Eric Dumazet , David Miller , netdev To: Chen Gang Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:33078 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315Ab2KVSqv (ORCPT ); Thu, 22 Nov 2012 13:46:51 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so6031694pbc.19 for ; Thu, 22 Nov 2012 10:46:50 -0800 (PST) In-Reply-To: <50AD9351.5020805@asianux.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi chen gang: =46or length of device name which less than 8 char=A3=AC your patch changes them to be print from align right=20 to align left. But at least since 2005(git age-time), we keep this style so far. Maybe, since birth of this code, just align right. :-) Why we *should* change this style? just keep be consistent with the case which length of device name greater than 8 char? Not only old name rule i.e. eth0,eth1, but also new name rule base on pci address ,i.e. em1,p3p1. most of them are less than 8 char. Should not we take more attention on the case less than 8 char? By addition, if we want to add new field in the future, align right is a better choice. Chen Gang said, at 2012/11/22 10:52: > Hi Shan Wei, Eric Dumazet >=20 > is this patch integrated into main branch ? > if need me for additional completion (such as: merge another 2 triv= ial patches into this patch, too) > please tell me, I will do.=20 >=20 > I understand you are working overtime, maybe no time for any minor = and trivial patches. > if surely it is, I think: > you can modify these code manually, and obsolete these minor and = trivial patches which I provided. > I do not mind whether mention me in another new patches (you can = mention me or not mention me, both are OK). > since our goal is to provide contributes to outside, efficiently. >=20 > regards >=20 > gchen >=20 >=20 > =D3=DA 2012=C4=EA11=D4=C205=C8=D5 11:02, Chen Gang =D0=B4=B5=C0: >> >> 1. not to send same patch triple times.=20 >=20 > thanks, I shall notice, next time. > (I shall 'believe' another members). >=20 >> 2. config your email client,because tab is changed to space. >> you can read Documentation/email-clients.txt. >=20 > 1) thanks. I shall notice, next time. > 2) now, I get gvim as extention editor for thounderbird > 3) the patch is generated by `git format-patch -s --summary --stat` > it use "' '\t" as head, I do not touch it, maybe it is correct. >=20 > welcome any members to giving additional suggestions and completions. >=20 > thanks >=20 > the modified contents are below, > ---------------------------------------------------------------------= -------------- >=20 > the length of rt->dst.dev->name is 16 (IFNAMSIZ) > in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. > so change it to %s, since each line has not been solid any more. >=20 > additional information: >=20 > %8s limit the width, not for the original string output length > if name length is more than 8, it still can be fully display= ed. > if name length is less than 8, the ' ' will be filled before= name. >=20 > %.8s truly limit the original string output length (precision) >=20 > Signed-off-by: Chen Gang > --- > net/ipv6/route.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index c42650c..b60bc52 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, = void *p_arg) > } else { > seq_puts(m, "00000000000000000000000000000000"); > } > - seq_printf(m, " %08x %08x %08x %08x %8s\n", > + seq_printf(m, " %08x %08x %08x %08x %s\n", > rt->rt6i_metric, atomic_read(&rt->dst.__refcnt), > rt->dst.__use, rt->rt6i_flags, > rt->dst.dev ? rt->dst.dev->name : ""); >=20 >=20 >=20