From: Chen Gang <gang.chen@asianux.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: ipmr: limit MRT_TABLE identifiers
Date: Mon, 26 Nov 2012 10:30:02 +0800 [thread overview]
Message-ID: <50B2D42A.6090804@asianux.com> (raw)
In-Reply-To: <1353896372.30446.866.camel@edumazet-glaptop>
于 2012年11月26日 10:19, Eric Dumazet 写道:
> On Mon, 2012-11-26 at 09:34 +0800, Chen Gang wrote:
>
>> if "pimre%u" (or another format), will not hurt the functional features, I suggest to use it
>> since, we need try our best to not touch the OS API.
>> ("pimreg%u" seems an internal format, not OS API Level)
>
> Have you taken a look at user code base before suggesting such a
> change ?
maybe a hacker can do ? (I just guess).
for my experience:
It is necessary to think of more coding ways, when we have to give comments inside a function.
>
> My patch is the safest change: Just make sure machine doesnt crash if
> user ask stupid things.
>
> No possible regression.
>
>
>
>
>
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2012-11-26 2:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 9:20 [Suggestion] net/ipv4: sprintf, use "pimreg%.9u" instead of "pimreg%u" Chen Gang
2012-11-25 19:44 ` [PATCH] net: ipmr: limit MRT_TABLE identifiers Eric Dumazet
2012-11-26 1:22 ` Chen Gang
2012-11-26 1:34 ` Chen Gang
2012-11-26 2:19 ` Eric Dumazet
2012-11-26 2:30 ` Chen Gang [this message]
2012-11-26 2:55 ` Eric Dumazet
2012-11-26 3:13 ` Chen Gang
2012-11-26 22:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B2D42A.6090804@asianux.com \
--to=gang.chen@asianux.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox