* [PATCH 1/2] of_mdio: Honour "status=disabled" property of device
@ 2012-11-29 7:45 Alexander Sverdlin
2012-11-29 17:12 ` Rob Herring
2012-11-29 17:36 ` Grant Likely
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Sverdlin @ 2012-11-29 7:45 UTC (permalink / raw)
To: Stephen Warren, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
Rob Herring, Grant Likely
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Barry.Song-kQvG35nSl+M,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ, alexander sverdlin
From: Alexander Sverdlin <alexander.sverdlin-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>
of_mdio: Honour "status=disabled" property of device
Currently of_mdiobus_register() function registers all PHY devices,
independetly from their status property in device tree. According to
"ePAPR 1.1" spec, device should only be registered if there is no
"status" property, or it has "ok" (or "okay") value (see
of_device_is_available()). In case of "platform devices",
of_platform_device_create_pdata() checks for "status" and ensures
that disabled devices are not pupulated. But such check for MDIO buses
was missing until now. Fix it.
Signed-off-by: Alexander Sverdlin <alexander.sverdlin-uSbOeAmDUekAvxtiuMwx3w@public.gmane.org>
---
--- linux.orig/drivers/of/of_mdio.c
+++ linux/drivers/of/of_mdio.c
@@ -53,7 +53,7 @@ int of_mdiobus_register(struct mii_bus *
return rc;
/* Loop over the child nodes and register a phy_device for each one */
- for_each_child_of_node(np, child) {
+ for_each_available_child_of_node(np, child) {
const __be32 *paddr;
u32 addr;
int len;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] of_mdio: Honour "status=disabled" property of device
2012-11-29 7:45 [PATCH 1/2] of_mdio: Honour "status=disabled" property of device Alexander Sverdlin
@ 2012-11-29 17:12 ` Rob Herring
2012-11-29 17:36 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2012-11-29 17:12 UTC (permalink / raw)
To: Alexander Sverdlin
Cc: Stephen Warren, devicetree-discuss, Rob Herring, Grant Likely,
netdev, Barry.Song, w.sang, alexander sverdlin
On 11/29/2012 01:45 AM, Alexander Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
>
> of_mdio: Honour "status=disabled" property of device
>
> Currently of_mdiobus_register() function registers all PHY devices,
> independetly from their status property in device tree. According to
> "ePAPR 1.1" spec, device should only be registered if there is no
> "status" property, or it has "ok" (or "okay") value (see
> of_device_is_available()). In case of "platform devices",
> of_platform_device_create_pdata() checks for "status" and ensures
> that disabled devices are not pupulated. But such check for MDIO buses
> was missing until now. Fix it.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
> ---
Applied.
Rob
> --- linux.orig/drivers/of/of_mdio.c
> +++ linux/drivers/of/of_mdio.c
> @@ -53,7 +53,7 @@ int of_mdiobus_register(struct mii_bus *
> return rc;
>
> /* Loop over the child nodes and register a phy_device for each one */
> - for_each_child_of_node(np, child) {
> + for_each_available_child_of_node(np, child) {
> const __be32 *paddr;
> u32 addr;
> int len;
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] of_mdio: Honour "status=disabled" property of device
2012-11-29 7:45 [PATCH 1/2] of_mdio: Honour "status=disabled" property of device Alexander Sverdlin
2012-11-29 17:12 ` Rob Herring
@ 2012-11-29 17:36 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-11-29 17:36 UTC (permalink / raw)
To: Alexander Sverdlin, Stephen Warren, devicetree-discuss,
Rob Herring
Cc: alexander sverdlin, w.sang, Barry.Song, netdev
On Thu, 29 Nov 2012 08:45:20 +0100, Alexander Sverdlin <asv@sysgo.com> wrote:
> From: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
>
> of_mdio: Honour "status=disabled" property of device
>
> Currently of_mdiobus_register() function registers all PHY devices,
> independetly from their status property in device tree. According to
> "ePAPR 1.1" spec, device should only be registered if there is no
> "status" property, or it has "ok" (or "okay") value (see
> of_device_is_available()). In case of "platform devices",
> of_platform_device_create_pdata() checks for "status" and ensures
> that disabled devices are not pupulated. But such check for MDIO buses
> was missing until now. Fix it.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
Applied, thanks.
g.
> ---
> --- linux.orig/drivers/of/of_mdio.c
> +++ linux/drivers/of/of_mdio.c
> @@ -53,7 +53,7 @@ int of_mdiobus_register(struct mii_bus *
> return rc;
>
> /* Loop over the child nodes and register a phy_device for each one */
> - for_each_child_of_node(np, child) {
> + for_each_available_child_of_node(np, child) {
> const __be32 *paddr;
> u32 addr;
> int len;
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-29 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-29 7:45 [PATCH 1/2] of_mdio: Honour "status=disabled" property of device Alexander Sverdlin
2012-11-29 17:12 ` Rob Herring
2012-11-29 17:36 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).