[PATCH net-next 2/2] net: doc: add default value for neighbour parameters

[PATCH net-next 2/2] net: doc: add default value for neighbour parameters

[Shan Wei]

From: Shan Wei <davidshan@tencent.com>

Signed-off-by: Shan Wei <davidshan@tencent.com>
---
 Documentation/networking/ip-sysctl.txt |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index c6d5fee..0462a71 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -30,16 +30,24 @@ neigh/default/gc_thresh3 - INTEGER
 	Maximum number of neighbor entries allowed.  Increase this
 	when using large numbers of interfaces and when communicating
 	with large numbers of directly-connected peers.
+	Default: 1024
 
 neigh/default/unres_qlen_bytes - INTEGER
 	The maximum number of bytes which may be used by packets
 	queued for each	unresolved address by other network layers.
 	(added in linux 3.3)
+	Seting negative value is meaningless and will retrun error.
+	Default: 65536 Bytes(64KB)
 
 neigh/default/unres_qlen - INTEGER
 	The maximum number of packets which may be queued for each
 	unresolved address by other network layers.
 	(deprecated in linux 3.3) : use unres_qlen_bytes instead.
+	Prior to linux 3.3, the default value is 3 which may cause
+	secluded packet loss. The current default value is calculated
+	according to default value of unres_qlen_bytes and true size of
+	packet.
+	Default: 31
 
 mtu_expires - INTEGER
 	Time, in seconds, that cached PMTU information is kept.
-- 
1.7.1

Re: [PATCH net-next 2/2] net: doc: add default value for neighbour parameters

[David Miller]

From: Shan Wei <shanwei88@gmail.com>
Date: Wed, 05 Dec 2012 12:50:35 +0800

> From: Shan Wei <davidshan@tencent.com>
> 
> Signed-off-by: Shan Wei <davidshan@tencent.com>

Applied.

Re: [PATCH net-next 2/2] net: doc: add default value for neighbour parameters

[Ben Hutchings]

On Wed, 2012-12-05 at 12:50 +0800, Shan Wei wrote:
> From: Shan Wei <davidshan@tencent.com>
> 
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> ---
>  Documentation/networking/ip-sysctl.txt |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index c6d5fee..0462a71 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -30,16 +30,24 @@ neigh/default/gc_thresh3 - INTEGER
>  	Maximum number of neighbor entries allowed.  Increase this
>  	when using large numbers of interfaces and when communicating
>  	with large numbers of directly-connected peers.
> +	Default: 1024
>  
>  neigh/default/unres_qlen_bytes - INTEGER
>  	The maximum number of bytes which may be used by packets
>  	queued for each	unresolved address by other network layers.
>  	(added in linux 3.3)
> +	Seting negative value is meaningless and will retrun error.
> +	Default: 65536 Bytes(64KB)
>  
>  neigh/default/unres_qlen - INTEGER
>  	The maximum number of packets which may be queued for each
>  	unresolved address by other network layers.
>  	(deprecated in linux 3.3) : use unres_qlen_bytes instead.
> +	Prior to linux 3.3, the default value is 3 which may cause
> +	secluded packet loss. The current default value is calculated
          ^^^^^^^^
I think the proper word here is 'silent'?

> +	according to default value of unres_qlen_bytes and true size of
> +	packet.
> +	Default: 31
>  
>  mtu_expires - INTEGER
>  	Time, in seconds, that cached PMTU information is kept.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: [PATCH net-next 2/2] net: doc: add default value for neighbour parameters

[Shan Wei]

Ben Hutchings said, at 2012/12/6 9:43:
>>  neigh/default/unres_qlen - INTEGER
>>  	The maximum number of packets which may be queued for each
>>  	unresolved address by other network layers.
>>  	(deprecated in linux 3.3) : use unres_qlen_bytes instead.
>> +	Prior to linux 3.3, the default value is 3 which may cause
>> +	secluded packet loss. The current default value is calculated
>           ^^^^^^^^
> I think the proper word here is 'silent'?
 
The number of lost packets is recorded in unresolved_discards
of /proc/net/stat/arp_cache. Although, arp_cache is not easy
to understand(I still don't know why we need so many rows),
We can confirm dropping event from unresolved_discards in last column.
The dropping event is not marked by absence of sound.

But for general user who using TCP/UDP or ping to sending packets
out, can't simply find the dropping reason that destination ip is unresolved.
They just doubt about the TCP/UDP or ping. So I use 'secluded' which is hidden
from general view.

My English is not good enough, if missing something, please point to me.
Thanks.

Best Regards
Shan Wei

Re: [PATCH net-next 2/2] net: doc: add default value for neighbour parameters

[Ben Hutchings]

On Thu, 2012-12-06 at 10:58 +0800, Shan Wei wrote:
> Ben Hutchings said, at 2012/12/6 9:43:
> >>  neigh/default/unres_qlen - INTEGER
> >>  	The maximum number of packets which may be queued for each
> >>  	unresolved address by other network layers.
> >>  	(deprecated in linux 3.3) : use unres_qlen_bytes instead.
> >> +	Prior to linux 3.3, the default value is 3 which may cause
> >> +	secluded packet loss. The current default value is calculated
> >           ^^^^^^^^
> > I think the proper word here is 'silent'?
>  
> The number of lost packets is recorded in unresolved_discards
> of /proc/net/stat/arp_cache. Although, arp_cache is not easy
> to understand(I still don't know why we need so many rows),
> We can confirm dropping event from unresolved_discards in last column.
> The dropping event is not marked by absence of sound.
> 
> But for general user who using TCP/UDP or ping to sending packets
> out, can't simply find the dropping reason that destination ip is unresolved.
> They just doubt about the TCP/UDP or ping. So I use 'secluded' which is hidden
> from general view.
> 
> My English is not good enough, if missing something, please point to me.
> Thanks.

'Secluded' is a fine word but your dictionary should have said that it
is used to describe places, not events.  You're quite right that this is
not silent, though.  So a word like 'hidden', 'quiet', 'non-obvious' or
'unexpected' would be more appropriate.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: [PATCH net-next 2/2] net: doc: add default value for neighbour parameters

[Shan Wei]

Ben Hutchings said, at 2012/12/7 4:20:
> 'Secluded' is a fine word but your dictionary should have said that it
> is used to describe places, not events.  You're quite right that this is
> not silent, though.  So a word like 'hidden', 'quiet', 'non-obvious' or
> 'unexpected' would be more appropriate.

You are right，good suggestion :-).
Thanks for your review.

-------------------------
[PATCH net-next] net: doc : use more suitable word 'unexpected' to replace 'secluded'

 'secluded' is used to describe places, not suitable here.

Suggested-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Shan Wei <davidshan@tencent.com>
---
 Documentation/networking/ip-sysctl.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 0462a71..1b830ca 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -44,7 +44,7 @@ neigh/default/unres_qlen - INTEGER
 	unresolved address by other network layers.
 	(deprecated in linux 3.3) : use unres_qlen_bytes instead.
 	Prior to linux 3.3, the default value is 3 which may cause
-	secluded packet loss. The current default value is calculated
+	unexpected packet loss. The current default value is calculated
 	according to default value of unres_qlen_bytes and true size of
 	packet.
 	Default: 31
-- 
1.7.1

Re: [PATCH net-next 2/2] net: doc: add default value for neighbour parameters

[David Miller]

From: Shan Wei <shanwei88@gmail.com>
Date: Fri, 07 Dec 2012 10:27:51 +0800

> [PATCH net-next] net: doc : use more suitable word 'unexpected' to replace 'secluded'
> 
>  'secluded' is used to describe places, not suitable here.
> 
> Suggested-by: Ben Hutchings <bhutchings@solarflare.com>
> Signed-off-by: Shan Wei <davidshan@tencent.com>

Applied.