From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH] sctp: Fix compiler warning when CONFIG_DEBUG_SECTION_MISMATCH=y Date: Thu, 06 Dec 2012 09:40:05 -0500 Message-ID: <50C0AE45.3030902@gmail.com> References: <1354798992-25622-1-git-send-email-christoph.paasch@uclouvain.be> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-sctp@vger.kernel.org, davem@davemloft.net, sri@us.ibm.com, nhorman@tuxdriver.com, netdev@vger.kernel.org To: Christoph Paasch Return-path: Received: from mail-ia0-f174.google.com ([209.85.210.174]:54744 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423553Ab2LFOqQ (ORCPT ); Thu, 6 Dec 2012 09:46:16 -0500 Received: by mail-ia0-f174.google.com with SMTP id y25so5469442iay.5 for ; Thu, 06 Dec 2012 06:46:15 -0800 (PST) In-Reply-To: <1354798992-25622-1-git-send-email-christoph.paasch@uclouvain.be> Sender: netdev-owner@vger.kernel.org List-ID: On 12/06/2012 08:03 AM, Christoph Paasch wrote: > WARNING: net/sctp/sctp.o(.text+0x72f1): Section mismatch in reference > from the function sctp_net_init() to the function > .init.text:sctp_proc_init() > The function sctp_net_init() references > the function __init sctp_proc_init(). > This is often because sctp_net_init lacks a __init > annotation or the annotation of sctp_proc_init is wrong. > > And put __net_init after 'int' for sctp_proc_init - as it is done > everywhere else in the sctp-stack. > > Signed-off-by: Christoph Paasch Acked-by: Vlad Yasevich -vlad > --- > net/sctp/protocol.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 456bc3d..2c7785b 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -86,7 +86,7 @@ int sysctl_sctp_rmem[3]; > int sysctl_sctp_wmem[3]; > > /* Set up the proc fs entry for the SCTP protocol. */ > -static __net_init int sctp_proc_init(struct net *net) > +static int __net_init sctp_proc_init(struct net *net) > { > #ifdef CONFIG_PROC_FS > net->sctp.proc_net_sctp = proc_net_mkdir(net, "sctp", net->proc_net); > @@ -1165,7 +1165,7 @@ static void sctp_v4_del_protocol(void) > unregister_inetaddr_notifier(&sctp_inetaddr_notifier); > } > > -static int sctp_net_init(struct net *net) > +static int __net_init sctp_net_init(struct net *net) > { > int status; > > @@ -1290,7 +1290,7 @@ err_sysctl_register: > return status; > } > > -static void sctp_net_exit(struct net *net) > +static void __net_exit sctp_net_exit(struct net *net) > { > /* Free the local address list */ > sctp_free_addr_wq(net); >