From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: Amir Vadai <amirv@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>,
Yan Burman <yanb@mellanox.com>,
Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH net-next 1/2] net: ethtool: Add destination MAC address to flow steering API
Date: Tue, 11 Dec 2012 12:57:53 -0800 [thread overview]
Message-ID: <50C79E51.1000904@intel.com> (raw)
In-Reply-To: <CAJZOPZJfqdrxKp8ZPTXs_-07XSdPoKu+bNQNZzkeTRgP-R2XnQ@mail.gmail.com>
On 12/11/2012 11:55 AM, Or Gerlitz wrote:
> On Tue, Dec 11, 2012 at 7:37 PM, Alexander Duyck
> <alexander.h.duyck@intel.com> wrote:
>>
>> Is there any special reason why you need to change the size of this
>> structure? It seems like you could probably just replace the data
>> section with a union containing either 8 bytes of user specified data or
>> your MAC address data. Then we wouldn't need all of the changes to the
>> rest of the flow specifier.
>
>
> basically, we followed Ben's suggestions made here
> http://marc.info/?t=134977576500003
>
After looking over Ben's suggestion it makes sense.
Since I am pretty much responsible for the ixgbe implementation of this
I will do a few quick tests once the patches are applied to make certain
that there were no issues introduced on our end.
Thanks,
Alex
next prev parent reply other threads:[~2012-12-11 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 12:03 [PATCH net-next 0/3] Add destination MAC address to ethtool flow steering Amir Vadai
2012-12-11 12:03 ` [PATCH net-next 1/2] net: ethtool: Add destination MAC address to flow steering API Amir Vadai
2012-12-11 17:37 ` Alexander Duyck
2012-12-11 19:55 ` Or Gerlitz
2012-12-11 20:57 ` Alexander Duyck [this message]
2012-12-12 17:17 ` Ben Hutchings
2012-12-11 12:03 ` [PATCH net-next 2/2] net/mlx4_en: Add support for destination MAC in steering rules Amir Vadai
2012-12-11 15:38 ` Brian Haley
2012-12-12 10:07 ` Amir Vadai
2012-12-11 12:03 ` [PATCH ETHTOOL] Added dst-mac parameter for L3/L4 flow spec rules. This is usefull in vSwitch configurations Amir Vadai
2013-01-22 20:27 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C79E51.1000904@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=amirv@mellanox.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=or.gerlitz@gmail.com \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).