From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Ani Sinha <ani@aristanetworks.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] net: filter: return -EINVAL if BPF_S_ANC* operation is not supported
Date: Wed, 12 Dec 2012 10:38:01 +0100 [thread overview]
Message-ID: <50C85079.4010209@redhat.com> (raw)
In-Reply-To: <1355304701-22228-1-git-send-email-dborkman@redhat.com>
On 12/12/2012 10:31 AM, Daniel Borkmann wrote:
> Currently, we return -EINVAL for malicious or wrong BPF filters.
> However, this is not done for BPF_S_ANC* operations, which makes it
> more difficult to detect if it's actually supported or not by the
> BPF machine. Therefore, we should also return -EINVAL if K is within
> the SKF_AD_OFF universe and the ancillary operation did not match.
>
> Cc: Ani Sinha <ani@aristanetworks.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
(Sorry, this is intended for net-next.)
next prev parent reply other threads:[~2012-12-12 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 9:31 [PATCH] net: filter: return -EINVAL if BPF_S_ANC* operation is not supported Daniel Borkmann
2012-12-12 9:38 ` Daniel Borkmann [this message]
2012-12-12 12:22 ` Eric Dumazet
2012-12-12 16:25 ` Daniel Borkmann
2012-12-12 22:06 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C85079.4010209@redhat.com \
--to=dborkman@redhat.com \
--cc=ani@aristanetworks.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).