From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: Jan Synacek <jsynacek@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] iputils: minor ninfod and ping6 fixes
Date: Thu, 20 Dec 2012 06:05:35 +0900 [thread overview]
Message-ID: <50D22C1F.8010509@linux-ipv6.org> (raw)
In-Reply-To: <1354868724-15549-1-git-send-email-jsynacek@redhat.com>
Jan Synacek wrote:
> When calling ping6 with the flowlabel (e.g. `ping6 -F 123 ::1'), it exited with
> an error. For some reason, the errno was set when it should not have been. Maybe
> it shouldn't be checked at all, maybe just checking flowlabel for values below
> zero would be enough. I wanted to be on the safer side so I left the errno check
> in there.
>
> Also, I fixed the rest of the unused variables in ninfod.
>
> Jan Synacek (2):
> ninfod: Fix more unused variables.
> ping6: Fix -F switch.
>
> ninfod/ni_ifaddrs.c | 8 +-------
> ping6.c | 3 ++-
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
Fixes committed. Thank you!
--yoshfuji
prev parent reply other threads:[~2012-12-19 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 8:25 [PATCH 0/2] iputils: minor ninfod and ping6 fixes Jan Synacek
2012-12-07 8:25 ` [PATCH 1/2] ninfod: Fix more unused variables Jan Synacek
2012-12-07 8:25 ` [PATCH 2/2] ping6: Fix -F switch Jan Synacek
2012-12-10 9:58 ` Jan Synacek
2012-12-10 10:12 ` [PATCH 2/2 fixed] " Jan Synacek
2012-12-19 21:05 ` YOSHIFUJI Hideaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D22C1F.8010509@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=jsynacek@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).