From: Brian Haley <brian.haley@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Dave Jones <davej@redhat.com>, netdev@vger.kernel.org
Subject: Re: sock_ioctl sleeping while atomic warning during boot.
Date: Thu, 20 Dec 2012 22:31:03 -0500 [thread overview]
Message-ID: <50D3D7F7.2030200@hp.com> (raw)
In-Reply-To: <1356060308.21834.4455.camel@edumazet-glaptop>
On 12/20/2012 10:25 PM, Eric Dumazet wrote:
> OK, thanks for the report.
>
> We need a seqcount, not a seqlock, as RTNL already protects multiple
> writers.
>
> Please try following fix :
>
>
> [PATCH] net: devnet_rename_seq should be a seqcount
>
> Using a seqlock for devnet_rename_seq is not a good idea,
> as device_rename() can sleep.
>
> As we hold RTNL, we dont need a protection for writers,
> and only need a seqcount so that readers can catch a change done
> by a writer.
>
> Bug added in commit c91f6df2db4972d3 (sockopt: Change getsockopt() of
> SO_BINDTODEVICE to return an interface name)
>
> Reported-by: Dave Jones <davej@redhat.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Brian Haley <brian.haley@hp.com>
Sorry about that, thanks for the quick fix Eric.
-Brian
next prev parent reply other threads:[~2012-12-21 3:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 2:24 sock_ioctl sleeping while atomic warning during boot Dave Jones
2012-12-21 3:25 ` Eric Dumazet
2012-12-21 3:31 ` Brian Haley [this message]
2012-12-21 21:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D3D7F7.2030200@hp.com \
--to=brian.haley@hp.com \
--cc=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).