From: Einar Lueck <elelueck@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, ubacher@de.ibm.com,
raspl@de.ibm.com, frankbla@de.ibm.com, samudrala@us.ibm.com
Subject: Re: [RFC PATCH V2] tcp: introduce raw access to experimental options
Date: Tue, 08 Jan 2013 15:36:35 +0100 [thread overview]
Message-ID: <50EC2EF3.5080506@linux.vnet.ibm.com> (raw)
In-Reply-To: <1357577051.6919.3171.camel@edumazet-glaptop>
On 01/07/2013 05:44 PM, Eric Dumazet wrote:
>
> Thats a big addition, and for example doesn't help if the SYNACK should
> include an option that is depending on the content of SYN message.
>
> For TCP fastopen for example, the cookie we send to the client is not a
> constant cookie.
>
> Also TCP coalescing of TCP collapse will merge several skbs, so storing
> "the last received options" in the socket is kind of not well defined
> semantic.
>
> It looks like you need to add hooks and kernel modules to fully use
> experimental options, like congestion control modules.
>
>
Thanks for the fast feedback, Eric. Let me try to make sure that I
understand your suggestions correctly:
You suggest to have a set of hooks that allow to move all code that
exploits experimental options into dedicated modules (e.g. one module
for TCP fastopen and one for cookies). Extensibility then comes on
a per module granularity. Is my understanding correct?
Thx,
Einar.
next prev parent reply other threads:[~2013-01-08 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 16:13 [RFC PATCH V2] tcp: introduce raw access to experimental options elelueck
2013-01-07 16:13 ` elelueck
2013-01-07 16:44 ` Eric Dumazet
2013-01-08 14:36 ` Einar Lueck [this message]
2013-01-08 22:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EC2EF3.5080506@linux.vnet.ibm.com \
--to=elelueck@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=frankbla@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=raspl@de.ibm.com \
--cc=samudrala@us.ibm.com \
--cc=ubacher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).