From: Stefan Assmann <sassmann@kpanic.de>
To: "Williams, Mitch A" <mitch.a.williams@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>
Subject: Re: [E1000-devel] [PATCH net-next] igbvf: fix setting addr_assign_type if PF is up
Date: Wed, 09 Jan 2013 18:58:30 +0100 [thread overview]
Message-ID: <50EDAFC6.3070700@kpanic.de> (raw)
In-Reply-To: <AAEA33E297BCAC4B9BB20A7C2DF0AB8D1F8B527A@FMSMSX107.amr.corp.intel.com>
On 09.01.2013 18:09, Williams, Mitch A wrote:
>> -----Original Message-----
>> From: Stefan Assmann [mailto:sassmann@kpanic.de]
>> Sent: Wednesday, January 09, 2013 1:59 AM
>> To: netdev@vger.kernel.org
>> Cc: e1000-devel@lists.sourceforge.net; sassmann@kpanic.de
>> Subject: [E1000-devel] [PATCH net-next] igbvf: fix setting
>> addr_assign_type if PF is up
>>
>> When the PF is up and igbvf is loaded the MAC address is not generated
>> using eth_hw_addr_random(). This results in addr_assign_type not to be
>> set.
>> Make sure it gets set.
>>
>
> NAK - In this case, the address may or may not be random. The user may
> have (and should have!) explicitly set this address from the host to
> ensure that the VF device receives the same address each time it boots.
Maybe you can give me some advice on this then. Why is there different
behaviour depending on the PF being up or down? The problem I'm facing
is that if the user did not set a MAC address for the VF manually and
the PF is up during igbvf_probe it will not be labelled as random
although it is.
What about checking IGB_VF_FLAG_PF_SET_MAC and only set NET_ADDR_RANDOM
if the flag is cleared?
Stefan
next prev parent reply other threads:[~2013-01-09 18:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 9:59 [PATCH net-next] igbvf: fix setting addr_assign_type if PF is up Stefan Assmann
2013-01-09 17:09 ` Williams, Mitch A
2013-01-09 17:58 ` Stefan Assmann [this message]
2013-01-09 18:56 ` [E1000-devel] " Williams, Mitch A
2013-01-09 19:53 ` Stefan Assmann
2013-01-09 21:37 ` Greg Rose
2013-01-14 22:25 ` Andy Gospodarek
2013-01-15 18:31 ` Greg Rose
2013-01-17 0:42 ` Williams, Mitch A
2013-01-17 1:06 ` Andy Gospodarek
2013-01-17 1:10 ` [E1000-devel] " Andy Gospodarek
2013-01-17 11:39 ` Stefan Assmann
2013-01-17 17:08 ` Greg Rose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EDAFC6.3070700@kpanic.de \
--to=sassmann@kpanic.de \
--cc=e1000-devel@lists.sourceforge.net \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).