[PATCH] net: Export __netdev_pick_tx so that it can be used in modules

[PATCH] net: Export __netdev_pick_tx so that it can be used in modules

[Alexander Duyck]

When testing with FCoE enabled we discovered that I had not exported
__netdev_pick_tx.  As a result ixgbe doesn't build with the RFC patches
applied because ixgbe_select_queue was calling the function.  This change
corrects that build issue by correctly exporting __netdev_pick_tx so it
can be used by modules.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 net/core/dev.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 95de4c0..d1e8116 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2746,6 +2746,7 @@ u16 __netdev_pick_tx(struct net_device *dev, struct sk_buff *skb)
 
 	return queue_index;
 }
+EXPORT_SYMBOL(__netdev_pick_tx);
 
 struct netdev_queue *netdev_pick_tx(struct net_device *dev,
 				    struct sk_buff *skb)

Re: [PATCH] net: Export __netdev_pick_tx so that it can be used in modules

[John Fastabend]

On 1/11/2013 10:38 AM, Alexander Duyck wrote:
> When testing with FCoE enabled we discovered that I had not exported
> __netdev_pick_tx.  As a result ixgbe doesn't build with the RFC patches
> applied because ixgbe_select_queue was calling the function.  This change
> corrects that build issue by correctly exporting __netdev_pick_tx so it
> can be used by modules.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---

Hi Alex,

If we get XPS to play nicely with the traffic class schemes we
can just remove select_queue completely.

I'll take a look tomorrow.

Thanks,
John

Re: [PATCH] net: Export __netdev_pick_tx so that it can be used in modules

[Alexander Duyck]

On 01/11/2013 11:02 AM, John Fastabend wrote:
> On 1/11/2013 10:38 AM, Alexander Duyck wrote:
>> When testing with FCoE enabled we discovered that I had not exported
>> __netdev_pick_tx.  As a result ixgbe doesn't build with the RFC patches
>> applied because ixgbe_select_queue was calling the function.  This change
>> corrects that build issue by correctly exporting __netdev_pick_tx so it
>> can be used by modules.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
>> ---
> 
> Hi Alex,
> 
> If we get XPS to play nicely with the traffic class schemes we
> can just remove select_queue completely.
> 
> I'll take a look tomorrow.
> 
> Thanks,
> John

Hi John,

It would be great if we could drop it entirely.

I just to make sure we are on the same page.  What you are saying is
that we could do that in addition to this patch correct?  I'm pretty
sure we will still need this patch in order to make this interface
available for any other drivers that would want to make use of transmit
packet steering instead of just the Tx hash.

Thanks,

Alex

Re: [PATCH] net: Export __netdev_pick_tx so that it can be used in modules

[John Fastabend]

On 1/11/2013 2:20 PM, Alexander Duyck wrote:
> On 01/11/2013 11:02 AM, John Fastabend wrote:
>> On 1/11/2013 10:38 AM, Alexander Duyck wrote:
>>> When testing with FCoE enabled we discovered that I had not exported
>>> __netdev_pick_tx.  As a result ixgbe doesn't build with the RFC patches
>>> applied because ixgbe_select_queue was calling the function.  This change
>>> corrects that build issue by correctly exporting __netdev_pick_tx so it
>>> can be used by modules.
>>>
>>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
>>> ---
>>
>> Hi Alex,
>>
>> If we get XPS to play nicely with the traffic class schemes we
>> can just remove select_queue completely.
>>
>> I'll take a look tomorrow.
>>
>> Thanks,
>> John
>
> Hi John,
>
> It would be great if we could drop it entirely.
>
> I just to make sure we are on the same page.  What you are saying is
> that we could do that in addition to this patch correct?  I'm pretty

Yes correct an additional patch on top of your work. This patch series
just got me thinking about it again.

.John

Re: [PATCH] net: Export __netdev_pick_tx so that it can be used in modules

[David Miller]

From: Alexander Duyck <alexander.h.duyck@intel.com>
Date: Fri, 11 Jan 2013 10:38:42 -0800

> When testing with FCoE enabled we discovered that I had not exported
> __netdev_pick_tx.  As a result ixgbe doesn't build with the RFC patches
> applied because ixgbe_select_queue was calling the function.  This change
> corrects that build issue by correctly exporting __netdev_pick_tx so it
> can be used by modules.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>

Applied.